Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dark mode): add light dismiss #959

Merged
merged 3 commits into from
Jan 16, 2023
Merged

chore(dark mode): add light dismiss #959

merged 3 commits into from
Jan 16, 2023

Conversation

rinaok
Copy link
Contributor

@rinaok rinaok commented Jan 16, 2023

No description provided.

@rinaok rinaok added this to the Q.4 22 🕛 milestone Jan 16, 2023
@rinaok rinaok requested a review from yinonov January 16, 2023 13:16
@rinaok rinaok self-assigned this Jan 16, 2023
@yinonov
Copy link
Contributor

yinonov commented Jan 16, 2023

to harden the feature #955

@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Merging #959 (65bde18) into main (d61b119) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              main      #959    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          123       209    +86     
  Lines         1562      2292   +730     
  Branches       108       132    +24     
==========================================
+ Hits          1562      2292   +730     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/components/src/lib/badge/badge.ts 100.00% <ø> (ø)
libs/components/src/lib/button/button.template.ts 100.00% <ø> (ø)
libs/components/src/lib/fab/fab.template.ts 100.00% <ø> (ø)
libs/components/src/lib/header/header.template.ts 100.00% <ø> (ø)
libs/components/src/lib/layout/layout.ts 100.00% <ø> (ø)
.../src/lib/accordion-item/accordion-item.template.ts 100.00% <100.00%> (ø)
...bs/components/src/lib/accordion-item/definition.ts 100.00% <100.00%> (ø)
libs/components/src/lib/accordion-item/index.ts 100.00% <100.00%> (ø)
libs/components/src/lib/accordion/definition.ts 100.00% <100.00%> (ø)
libs/components/src/lib/accordion/index.ts 100.00% <100.00%> (ø)
... and 163 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rinaok rinaok marked this pull request as draft January 16, 2023 14:56
@rinaok rinaok marked this pull request as ready for review January 16, 2023 14:59
@rinaok rinaok merged commit f107b94 into main Jan 16, 2023
@rinaok rinaok deleted the light-dismiss-dark-mode branch January 16, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants