-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy opener document's compatibility mode #128
Merged
Merged
+9
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 1, 2024
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 2, 2024
Currently, document picture-in-picture windows use quirks mode by default, since they're just about:blank windows. This CL makes the pip document match the opener document's compatibility mode instead. WICG/document-picture-in-picture#128 https://groups.google.com/a/chromium.org/g/blink-dev/c/IR7qdNj4Zyw Bug: 370423046 Change-Id: Ib1a84947b2408ae0be236afc2173fbcb0f77b598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5900737 Reviewed-by: Frank Liberato <[email protected]> Commit-Queue: Tommy Steimel <[email protected]> Reviewed-by: Nate Chapin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363338}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 2, 2024
Currently, document picture-in-picture windows use quirks mode by default, since they're just about:blank windows. This CL makes the pip document match the opener document's compatibility mode instead. WICG/document-picture-in-picture#128 https://groups.google.com/a/chromium.org/g/blink-dev/c/IR7qdNj4Zyw Bug: 370423046 Change-Id: Ib1a84947b2408ae0be236afc2173fbcb0f77b598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5900737 Reviewed-by: Frank Liberato <[email protected]> Commit-Queue: Tommy Steimel <[email protected]> Reviewed-by: Nate Chapin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363338}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Oct 10, 2024
…y mode as the opener, a=testonly Automatic update from web-platform-tests [document pip] Use the same compatibility mode as the opener Currently, document picture-in-picture windows use quirks mode by default, since they're just about:blank windows. This CL makes the pip document match the opener document's compatibility mode instead. WICG/document-picture-in-picture#128 https://groups.google.com/a/chromium.org/g/blink-dev/c/IR7qdNj4Zyw Bug: 370423046 Change-Id: Ib1a84947b2408ae0be236afc2173fbcb0f77b598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5900737 Reviewed-by: Frank Liberato <[email protected]> Commit-Queue: Tommy Steimel <[email protected]> Reviewed-by: Nate Chapin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363338} -- wpt-commits: 6a80672082519cb3f49bf5dc3cf705a0fe6982c3 wpt-pr: 48434
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Oct 12, 2024
…y mode as the opener, a=testonly Automatic update from web-platform-tests [document pip] Use the same compatibility mode as the opener Currently, document picture-in-picture windows use quirks mode by default, since they're just about:blank windows. This CL makes the pip document match the opener document's compatibility mode instead. WICG/document-picture-in-picture#128 https://groups.google.com/a/chromium.org/g/blink-dev/c/IR7qdNj4Zyw Bug: 370423046 Change-Id: Ib1a84947b2408ae0be236afc2173fbcb0f77b598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5900737 Reviewed-by: Frank Liberato <[email protected]> Commit-Queue: Tommy Steimel <[email protected]> Reviewed-by: Nate Chapin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363338} -- wpt-commits: 6a80672082519cb3f49bf5dc3cf705a0fe6982c3 wpt-pr: 48434
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 15, 2024
…y mode as the opener, a=testonly Automatic update from web-platform-tests [document pip] Use the same compatibility mode as the opener Currently, document picture-in-picture windows use quirks mode by default, since they're just about:blank windows. This CL makes the pip document match the opener document's compatibility mode instead. WICG/document-picture-in-picture#128 https://groups.google.com/a/chromium.org/g/blink-dev/c/IR7qdNj4Zyw Bug: 370423046 Change-Id: Ib1a84947b2408ae0be236afc2173fbcb0f77b598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5900737 Reviewed-by: Frank Liberato <liberatochromium.org> Commit-Queue: Tommy Steimel <steimelchromium.org> Reviewed-by: Nate Chapin <japhetchromium.org> Cr-Commit-Position: refs/heads/main{#1363338} -- wpt-commits: 6a80672082519cb3f49bf5dc3cf705a0fe6982c3 wpt-pr: 48434 UltraBlame original commit: b0067e7291835ec0f24ff19254a7373615c3a82d
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 15, 2024
…y mode as the opener, a=testonly Automatic update from web-platform-tests [document pip] Use the same compatibility mode as the opener Currently, document picture-in-picture windows use quirks mode by default, since they're just about:blank windows. This CL makes the pip document match the opener document's compatibility mode instead. WICG/document-picture-in-picture#128 https://groups.google.com/a/chromium.org/g/blink-dev/c/IR7qdNj4Zyw Bug: 370423046 Change-Id: Ib1a84947b2408ae0be236afc2173fbcb0f77b598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5900737 Reviewed-by: Frank Liberato <liberatochromium.org> Commit-Queue: Tommy Steimel <steimelchromium.org> Reviewed-by: Nate Chapin <japhetchromium.org> Cr-Commit-Position: refs/heads/main{#1363338} -- wpt-commits: 6a80672082519cb3f49bf5dc3cf705a0fe6982c3 wpt-pr: 48434 UltraBlame original commit: b0067e7291835ec0f24ff19254a7373615c3a82d
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 15, 2024
…y mode as the opener, a=testonly Automatic update from web-platform-tests [document pip] Use the same compatibility mode as the opener Currently, document picture-in-picture windows use quirks mode by default, since they're just about:blank windows. This CL makes the pip document match the opener document's compatibility mode instead. WICG/document-picture-in-picture#128 https://groups.google.com/a/chromium.org/g/blink-dev/c/IR7qdNj4Zyw Bug: 370423046 Change-Id: Ib1a84947b2408ae0be236afc2173fbcb0f77b598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5900737 Reviewed-by: Frank Liberato <liberatochromium.org> Commit-Queue: Tommy Steimel <steimelchromium.org> Reviewed-by: Nate Chapin <japhetchromium.org> Cr-Commit-Position: refs/heads/main{#1363338} -- wpt-commits: 6a80672082519cb3f49bf5dc3cf705a0fe6982c3 wpt-pr: 48434 UltraBlame original commit: b0067e7291835ec0f24ff19254a7373615c3a82d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #127