Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[document pip] Use the same compatibility mode as the opener #48434

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

Currently, document picture-in-picture windows use quirks mode by
default, since they're just about:blank windows. This CL makes the pip
document match the opener document's compatibility mode instead.

WICG/document-picture-in-picture#128

https://groups.google.com/a/chromium.org/g/blink-dev/c/IR7qdNj4Zyw

Bug: 370423046
Change-Id: Ib1a84947b2408ae0be236afc2173fbcb0f77b598
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5900737
Reviewed-by: Frank Liberato <[email protected]>
Commit-Queue: Tommy Steimel <[email protected]>
Reviewed-by: Nate Chapin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1363338}

Currently, document picture-in-picture windows use quirks mode by
default, since they're just about:blank windows. This CL makes the pip
document match the opener document's compatibility mode instead.

WICG/document-picture-in-picture#128

https://groups.google.com/a/chromium.org/g/blink-dev/c/IR7qdNj4Zyw

Bug: 370423046
Change-Id: Ib1a84947b2408ae0be236afc2173fbcb0f77b598
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5900737
Reviewed-by: Frank Liberato <[email protected]>
Commit-Queue: Tommy Steimel <[email protected]>
Reviewed-by: Nate Chapin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1363338}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 6a80672 into master Oct 2, 2024
20 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-68980cf26b branch October 2, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants