Converting CampaignAlerts class component to functional component #5397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That highlighted column header is a bug.
…On Wed, May 17, 2023, 5:07 PM Amine Hassou ***@***.***> wrote:
With reference to #5393
<#5393>
What this PR does
Converts campaign_alerts.jsx into a functional component. Also uses the
newer redux hooks
*Affected Pages:* /campaigns/[campaign_title]/alerts
Videos
Before:
before refactor assignment alerts.webm
<https://github.com/WikiEducationFoundation/WikiEduDashboard/assets/39999898/aaab269b-0ab8-4a7c-be52-99b2ee1a577a>
After:
after refactor assignment alerts.webm
<https://github.com/WikiEducationFoundation/WikiEduDashboard/assets/39999898/2fe75429-4b0e-4a4c-9c8d-8d76f6698fce>
Questions and Concerns
Unrelated question: I noticed that the "course" column in the alerts table
is always highlighted white even when sorting by date or other columns. Is
this intended design behaviour or is the white highlight supposed to change
based on the column that we're sorting by?
------------------------------
You can view, comment on, or merge this pull request online at:
#5397
Commit Summary
- d8507a6
<d8507a6>
Converted CampaignAlerts to functional component and used redux hooks
File Changes
(1 file
<https://github.com/WikiEducationFoundation/WikiEduDashboard/pull/5397/files>
)
- *M* app/assets/javascripts/components/alerts/campaign_alerts.jsx
<https://github.com/WikiEducationFoundation/WikiEduDashboard/pull/5397/files#diff-509fe64c0eda57bb5b5433f7dc3c84b8db85211fac6aa1201840cf5dc96116c9>
(98)
Patch Links:
-
https://github.com/WikiEducationFoundation/WikiEduDashboard/pull/5397.patch
-
https://github.com/WikiEducationFoundation/WikiEduDashboard/pull/5397.diff
—
Reply to this email directly, view it on GitHub
<#5397>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGPEYZBG2TF7KMJRC5LFS3XGVR3ZANCNFSM6AAAAAAYFYTVSQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Should I create an issue for it? I could work on it too. |
|
Sure, please do.
…On Wed, May 17, 2023, 5:39 PM Amine Hassou ***@***.***> wrote:
Should I create an issue for it? I could work on it too.
—
Reply to this email directly, view it on GitHub
<#5397 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGPEY7ATKVETPXEEJTS5FLXGVVURANCNFSM6AAAAAAYFYTVSQ>
.
You are receiving this because you commented.Message ID:
***@***.***
com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With reference to #5393
What this PR does
Converts campaign_alerts.jsx into a functional component. Also uses the newer redux hooks
Affected Pages:
/campaigns/[campaign_title]/alertsVideos
Before:
before.refactor.assignment.alerts.webm
After:
after.refactor.assignment.alerts.webm
Questions and Concerns
Unrelated question: I noticed that the "course" column in the alerts table is always highlighted white even when sorting by date or other columns. Is this intended design behaviour or is the white highlight supposed to change based on the column that we're sorting by?