Component refactor for React class components #5393
Comments
|
@justiceotuya is everything fine? |
|
|
|
if you are using windows, follow this step
https://github.com/WikiEducationFoundation/WikiEduDashboard/blob/master/docs/ubuntu_wsl_setup.md
…On Fri, Nov 3, 2023 at 2:12 PM amjido_01 ***@***.***> wrote:
I literally don't know what is happening along the way
—
Reply to this email directly, view it on GitHub
<#5393 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEG4BAHXSNQ6253EIAIXDM3YCTUS7AVCNFSM6AAAAAAYCO6CH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJSGQYTINZYHE>
.
You are receiving this because you commented.Message ID:
***@***.***
com>
|
yep that is exactly what i followed, and everything seems good except the last step that ask to run the command of "yarn build" then i get that error that i show |
|
@ragesoss @justiceotuya I mean the second to the last step that said to run "yarn build" is what is giving me error |
|
ok run bundle install |
|
@justiceotuya ok sir, let me give it a try |
|
@justiceotuya done with the bundle installation, what next sir |
|
@justiceotuya this is what i get after installing bundler. |
|
Try the yarn run or yarn start
…On Fri, 3 Nov 2023, 4:24 pm amjido_01, ***@***.***> wrote:
@justiceotuya <https://github.com/justiceotuya> this is what i get after
installing bundler.
[image: bundler]
<https://user-images.githubusercontent.com/96017433/280329856-823a7a4a-fd00-482c-83e5-b1ef11073a38.jpg>
—
Reply to this email directly, view it on GitHub
<#5393 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEG4BAETCN72Y7YYMPJY5GTYCUECLAVCNFSM6AAAAAAYCO6CH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJSGY2DEMRSGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
|
@justiceotuya then after installing the bundler, I then try running "yarn build" as stated in the setup.md. then this happen. |
|
@ragesoss @justiceotuya cannot load database configuration: |
|
Please follow the documentation on how to setup your database
…On Fri, 3 Nov 2023, 4:26 pm amjido_01, ***@***.***> wrote:
@justiceotuya <https://github.com/justiceotuya> then after installing the
bundler, I then try running "yarn build" as stated in the setup.md. then
this happen.
[image: build]
<https://user-images.githubusercontent.com/96017433/280330371-8d8e4fda-ddda-476d-a1e3-108d9c51b11a.jpg>
—
Reply to this email directly, view it on GitHub
<#5393 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEG4BADOVH7TLQJQRCB7V5TYCUEIZAVCNFSM6AAAAAAYCO6CH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJSGY2DMMBVHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
ok sir, thank you |
|
Hello @ragesoss |
|
hi @ragesoss I have set up the project locally just recently for the first time, but when I close the project and then later on try to run it again, I keep getting some weird issues, like "500 Internal Server Error |
|
This is not the right place for setup issues @amjido-01 . Check the troubleshooting docs, and then post on the dedicated setup problems issue if you're still stuck. |
NOTE TO NEW CONTRIBUTORS
Please only convert one component; choose a different issue after you've completed one. These are low-priority refactoring tasks, but they still require code review and careful checking for regressions and errors. In your PR, describe the manual testing you did to ensure that the component is still working the same way after the refactor, and include before/after screenshots of that show the component as it is used in the app. If the component is used many places, screenshots of multiple different uses is helpful.
Current Behavior:
At the moment, the React side of the codebase still uses around 163 class components. 134 of those class components use the legacy
createReactClassmethod while the other 29 class components use the newer class definitions. The 29 class components should be the main focus for the refactor. Once those are done, we can move on to the more legacy classesDesired Behavior:
Preferably, we want to only use functional components. Thus, converting the remaining class components into functional components would be a nice code quality improvement.
Checklist for newer classes to be converted:
Checklist for legacy classes to be converted:
The text was updated successfully, but these errors were encountered: