Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted StudentDrawer, QuestionResults, FollowUpQuestionResults, CourseAlertsList components into functional components #5406

Conversation

Aminehassou
Copy link
Contributor

@Aminehassou Aminehassou commented May 25, 2023

With reference to #5393

What this PR does

Converts StudentDrawer.jsx, QuestionResults.jsx, FollowUpQuestionResults.jsx and course_alerts_list.jsx into functional components.
Affected Pages:

  • /courses/[institution_id]/[course_id]/students/articles/[student_username] (for StudentDrawer.jsx)
  • /survey/results/[survey_id] (for QuestionResults.jsx and FollowUpQuestionResults.jsx)
  • /courses/[institution_id]/[course_id]/activity/alerts (for course_alerts_list.jsx)

Videos/Screenshots

Before StudentDrawer.jsx

before.refactor.studentDrawer.webm

After StudentDrawer.jsx

after.refactor.studentDrawer.webm

Before QuestionResults.jsx and FollowUpQuestionResults.jsx

before refactor FollowUpQuestionResults

After QuestionResults.jsx and FollowUpQuestionResults.jsx

after refactor FollowUpQuestionResults

Before course_alerts_list.jsx

before refactor CourseAlertsList

After course_alerts_list.jsx

after refactor CourseAlertsList

@Aminehassou Aminehassou marked this pull request as ready for review May 25, 2023 04:01
@ragesoss ragesoss merged commit 0a20992 into WikiEducationFoundation:master May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants