Converting TicketShowHandler, NewReplyFrom and NotificationsBell into functional components #5411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aminehassou
changed the title
Aminehassou
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With reference to #5393
What this PR does
Converts
ticket_show_handler.jsx,new_reply_form.jsxandnotifications_bell.jsxinto functional components.Affected Pages:
/tickets/dashboard/[ticket_id](forticket_show_handler.jsxandnew_reply_form.jsx)notifications_bell.jsx)Videos/Screenshots
Before
ticket_show_handler.jsxandnew_reply_form.jsxbefore.refactor.ticketshowhandler.and.newreplyform.webm
After
ticket_show_handler.jsxandnew_reply_form.jsxafter.refactor.ticketshowhandler.and.newreplyform.webm
Before
notifications_bell.jsxwith notifications:
without notifications:
After
notifications_bell.jsxwith notifications:
without notifications:
Questions/Concerns
I added a small visual feature to the ticket reply box. You can now see that when the reply box is empty, the reply buttons are disabled until the user starts typing. I thought this was a nice addition so I kept it in.