Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting CustomLink, UpdateDefaultCampaignSetting, UpdateSalesforceCredentials and UpdateCourseCreationSettings into functional component #5474

Conversation

Aminehassou
Copy link
Contributor

With reference to #5393

What this PR does

Converts CustomLink.jsx, update_default_campaign_setting.jsx, update_salesforce_credentials.jsx and update_course_creation_settings.jsx into functional components
Affected Pages:

  • /settings (for update_default_campaign_setting.jsx, update_salesforce_credentials.jsx and update_course_creation_settings.jsx)
  • Any page that has the main navbar (for CustomLink.jsx)

Videos

Before CustomLink.jsx

before.refactor.CustomLink.mp4

After CustomLink.jsx

after.refactor.CustomLink.mp4

Before update_default_campaign_setting.jsx, update_salesforce_credentials.jsx and update_course_creation_settings.jsx

before.refactor.UpdatingSettings.mp4

After update_default_campaign_setting.jsx, update_salesforce_credentials.jsx and update_course_creation_settings.jsx

after.refactor.UpdatingSettings.mp4

@ragesoss ragesoss merged commit ae440bc into WikiEducationFoundation:master Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants