Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data rearchitecture] sync with master #6096

Conversation

gabina
Copy link
Member

@gabina gabina commented Jan 6, 2025

What this PR does

Periodic sync with master. Automatic merge failed and I manually modified app/views/courses/articles.json.jbuilder

Open questions and concerns

< anything you learned that you want to share, or questions you're wondering about related to this PR >

cyrillefr and others added 30 commits May 2, 2024 22:15
- a new mailer + new template
- a new method in BlockUserAlert to mail to a set of concerned people
  which replace the current one in blocked_user_monitor.rb
- the corresponding spec
- new line in preview mailer
Refactor error handling in ArticleStatusManager to use ApiErrorHandling consistently
…mpaign-table-appears-when-closing-modals

Fix campaigns list rendering above recent news section  issue on index page when navigating back via cancel button
…rror-logging-course-update

Extend error logging for course data updates
- Deleted the unused ReviewerLink component.
- Removed the commented-out reference to ReviewerLink in the AssignmentsLinks component.
…remove-unused-reviewerlink

chore: Remove unused ReviewerLink component and cleanup related code
…nt to be available before interacting with it
…al is visible and the ok button rendered before interacting with it
…outreachy/improve-test-suite

Fix: failing test for assigned_article_spec
…or/student-view-navigation-course-page

Refactor components to use navigation utility hook for student details view
This feature isn't compatible with removing the Revisions table
…fix/account_request_spec

Fix: failing test in account_requests_spec
This is necessary as part of the project to deprecate the Revisions table.
ragesoss and others added 25 commits December 30, 2024 08:55
We have new PCORI reviews, and the links for all of them have changed.
I overlooked this change when I reimplemented the articleDetails to be completely client-side.
…ulate_logs

[FIX]: Unnecessary Logs, Preventing System Inefficiencies and Inefficient Retries While Populating Dashboard Database
…i page ID

- Added "crossCheckArticleTitle" function to verify and update article titles and URLs using the MediaWiki API based on the page ID.
- Introduced "UPDATE_ARTICLE_TITLE_AND_URL" action in the reducer to update article titles and URLs in the Redux store when article title is
changed.
- Updated "fetchArticleDetails" to integrate "crossCheckArticleTitle" for dynamic title validation and updates before if fetching article first and last revision fails.
- Enhanced handling of moved articles by verifying and updating titles via MediaWiki API by using "crossCheckArticleTitle" in ArticleViewer.
…ffviewer-handle-moved-articles

fix(DiffViewer & ArticleViewer): handle moved articles using MediaWik…
…tudentProgramEndpoint

Add student program endpoint
…ducationFoundation#6028)

* Fix: Improve meeting date extraction and validation in Week component

* Refactored the regex into a named-component

* changed the date extraction to the course_date_utils.js

* fixed the linting errors

* Fix issue with meeting display after the end date

* fix rspec test

* fix rspec tests and check if meetings go beyond timeline.end
…reen-reader-weekdaypicker-accessibility

Improve/Fix Accessibility for WeekdayPicker Component for Screen reader
…ove-documentation-phabT375642

Improve Documentation: Dashboard Deployment on Toolforge and Cloud VPS
…-to-admin-guide

Add links to admin_guide.md
…check for it (WikiEducationFoundation#6085)

* move StringConcatenation rule to 'permanent exceptions' section
…fix/multiwiki_student_role_spec

Fix: failure in Student_role_spec
@gabina
Copy link
Member Author

gabina commented Jan 6, 2025

There is one spec failing but I don't think this is related to my changes because it was failing recently in other PRs too.

1) multiwiki assignments will create a valid assignment for multilingual wikisource projects
     Failure/Error: expect(page).to have_content 'Heyder Cansa'
       expected to find text "Heyder Cansa" in "Students Assignments\nStudents OverviewAssignments & Exercises\nUsername\nFirst name\nLast name\nAdd/Remove Students\nRagesock\nRagesock\nsandboxes edits profile\nAssign/remove an article\nAssign/remove a peer review\nAssigned Articles\nName Relevant Links Current Stage Article Viewer\nHttpnsa\nBibliography • Sandbox Draft\n1/5. Getting Started\nRevisions\nNamespace Filter:\nAll\nMainspace\nUserspace\nTalk\nRecent Edits\nWords Added\n(article | user | draft)\nReferences Added\nTotal Uploads\n0 0 | 0 | 0 0 0"

@gabina gabina marked this pull request as ready for review January 6, 2025 18:59
@gabina gabina merged commit ad701f7 into WikiEducationFoundation:data-rearchitecture-for-dashboard Jan 6, 2025
1 check failed
@gabina gabina deleted the data-rearchitecture-sync-with-master branch January 6, 2025 19:01
Copy link

sentry-io bot commented Jan 8, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Cannot read properties of undefined (reading 'wiki') Fu.wikiUrl(app/assets/javascripts/components/re... View Issue
  • ‼️ ActiveRecord::RecordNotUnique: Mysql2::Error: Duplicate entry '1-58755-0-pileid' for key 'index_categories_on_wiki_id_and_name_a... CoursesController#manual_update View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.