Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix state immutability issues in the weeks property of the timeline slice by getWeeks selector. #6138

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix state immutability issues in the weeks property of the timeline slice by getWeeks selector. #6138

wants to merge 1 commit into from
+2 −2

Conversation

Abishekcs
Copy link
Contributor

@Abishekcs Abishekcs commented Jan 17, 2025 •
edited
Loading

What this PR does

Fixes state immutability issues in the weeks property of the timeline slice done by getWeeksArray selector.

Cause of Bug

  • The bug lies in the direct modification of the newWeek object, which is a reference to the weeks property of the Redux state.

Fix

Screenshots

Before:

Before.mp4

After:

After.mp4

This was referenced Jan 17, 2025
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Abishekcs