[ISSUE apache#8380]fix wrong election in controllerMode

Willhow-Gao · Jul 9, 2024 · c87eff0 · c87eff0
1 parent 2bc0014
commit c87eff0
Showing 1 changed file with 1 addition and 6 deletions.
diff --git a/...er/src/main/java/org/apache/rocketmq/controller/impl/manager/RaftReplicasInfoManager.java b/...er/src/main/java/org/apache/rocketmq/controller/impl/manager/RaftReplicasInfoManager.java
@@ -123,12 +123,7 @@ public ControllerResult<CheckNotActiveBrokerResponse> checkNotActiveBroker(Check
                 log.warn("Broker expired, brokerInfo {}, expired {}ms", next.getKey(), timeoutMillis);
             }
         }
-        List<String> needReElectBrokerNames = scanNeedReelectBrokerSets(new BrokerValidPredicate() {
-            @Override
-            public boolean check(String clusterName, String brokerName, Long brokerId) {
-                return !isBrokerActive(clusterName, brokerName, brokerId, checkTime);
-            }
-        });
+        List<String> needReElectBrokerNames = scanNeedReelectBrokerSets((clusterName, brokerName, brokerId) -> isBrokerActive(clusterName, brokerName, brokerId, checkTime));
         Set<String> alreadyReportedBrokerName = notActiveBrokerIdentityInfoList.stream()
             .map(BrokerIdentityInfo::getBrokerName)
             .collect(Collectors.toSet());