get field response with function #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettviren
reviewed
Aug 7, 2024
sigproc/src/OmnibusSigProc.cxx
Outdated
| @@ -790,7 +790,7 @@ void OmnibusSigProc::init_overall_response(IFrame::pointer frame) | |||
|
|
|||
| // Convert each average FR to a 2D array | |||
| for (int iplane = 0; iplane < 3; ++iplane) { | |||
| auto arr = Response::as_array(fravg.planes[iplane], fine_nwires, fine_nticks); | |||
| auto arr = Response::as_array(*(fravg.plane(iplane)), fine_nwires, fine_nticks); | |||
There was a problem hiding this comment.
This is a problem I only appreciate after seeing it as a code change. See my comment in #322.
|
Fixes #322 |
|
Aligned with a new proposal in #322, I would like to withdraw the previous solution. Now the following code will be removed in OmnibusSigProc: A new PR is submitted here: #325 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for ProtoDUNE HD and is discussed in issue #322
This is a non-breaking change, other experiment should not feel any change.