Configurable filter names #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brettviren Regarding our discussion in #322, I would like to withdraw my previous PR in #324 Now the new solution would be adding a plane-to-layer conversion only within OmnibusSigProc. Sorry for this "big" PR: configurable filter names + plane ID conversion. But since they are both for the ProtoDUNE HD APA1, I would like to put them together. I have added comments in all the other issues/tickets for a record. |
|
Here is a crosscheck result for the raw waveform and the deconvolution result from PDHD (2560*4 channels), which shows a reasonable implementation of both: 1) V-W induction/collection treatment , and 2) specific filter value for APA1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An example of usage would be: