Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocks: When a block specified in gutenberg_reregister_core_block_types() doesn't exist, following blocks are not registered #41121

Closed
dd32 opened this issue May 18, 2022 · 0 comments · Fixed by #41122
Closed

Blocks: When a block specified in gutenberg_reregister_core_block_types() doesn't exist, following blocks are not registered #41121

dd32 opened this issue May 18, 2022 · 0 comments · Fixed by #41122
Labels
[Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended

Comments

@dd32
Copy link
Member

dd32 commented May 18, 2022 •
edited
Loading

Description

When a Gutenberg build, such as version 13.2.1, includes a block in the array in gutenberg_reregister_core_block_types(), but that isn't included in the package for whatever reason, following blocks are not registered.

While I'm not sure if this situation should exist, it has, and has caused this: This has caused WordPress/wporg-news-2021#376

The Navigation-area block specified doesn't exist in Gutenberg 13.2.1:

gutenberg/lib/blocks.php

Line 74 in 14c0c1d

'navigation-area.php' => 'core/navigation-area',
+ https://plugins.trac.wordpress.org/browser/gutenberg/tags/13.2.1/build/block-library/blocks

See PR.

Step-by-step reproduction instructions

  1. Install Gutenberg 13.2.1
  2. Attempt to use the post-author-name block
  3. Experience the lack of a block

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

No
@dd32 dd32 added the [Feature] Blocks Overall functionality of blocks label May 18, 2022
dd32 added a commit that referenced this issue May 18, 2022
@dd32
Don't abort registering blocks when a missing block file is found.
444fce3 
Fixes #41121
@dd32 dd32 mentioned this issue May 18, 2022
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 18, 2022
@dd32 dd32 mentioned this issue May 18, 2022
Closed
@dd32 dd32 added the [Type] Bug An existing feature does not function as intended label May 18, 2022
@dd32 dd32 removed their assignment May 19, 2022
Mamaduka pushed a commit that referenced this issue May 19, 2022
@dd32
Blocks: Don't abort registering blocks when a missing block file is f…
97474fa 
…ound. (#41122)

* Don't abort registering blocks when a missing block file is found.
* Blocks: Don't return early on a malformed block.json
* Fixes #41121
chad1008 pushed a commit that referenced this issue May 19, 2022
@dd32 @chad1008
Blocks: Don't abort registering blocks when a missing block file is f…
7efbbea 
…ound. (#41122)

* Don't abort registering blocks when a missing block file is found.
* Blocks: Don't return early on a malformed block.json
* Fixes #41121
chad1008 pushed a commit that referenced this issue May 19, 2022
@dd32 @chad1008
Blocks: Don't abort registering blocks when a missing block file is f…
a7b42e0 
…ound. (#41122)

* Don't abort registering blocks when a missing block file is found.
* Blocks: Don't return early on a malformed block.json
* Fixes #41121
This was referenced May 20, 2022
Merged
Merged
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Blocks: Don't abort registering blocks when a missing block file is found. WordPress/gutenberg
2 participants
@dd32 @priethor