Remove all references to the navigation areas #41205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
[Type] Bug
adamziel
changed the title
|
Size Change: 0 B Total Size: 1.24 MB ℹ️ View Unchanged
|
getdave
reviewed
May 24, 2022
| @@ -71,7 +71,6 @@ function gutenberg_reregister_core_block_types() { | |||
| 'latest-posts.php' => 'core/latest-posts', | |||
| 'loginout.php' => 'core/loginout', | |||
| 'navigation.php' => 'core/navigation', | |||
| 'navigation-area.php' => 'core/navigation-area', | |||
There was a problem hiding this comment.
Oh man how did we miss this 🤦
getdave
reviewed
May 24, 2022
| // which the Contributor level user does not have. | ||
| // See: https://github.com/WordPress/gutenberg/blob/4cedaf0c4abb0aeac4bfd4289d63e9889efe9733/lib/class-wp-rest-block-navigation-areas-controller.php#L81-L91. | ||
| // Todo: removed once Nav Areas are removed from the Gutenberg Plugin. | ||
| expect( console ).toHaveErrored(); |
There was a problem hiding this comment.
Actually, we can't remove it as there are still quite a few 403 errors in the console:
I'll just update the comment and leave the expect() in
adamziel
requested review from
gziolo,
ryanwelcher,
ellatrix,
ZebulanStanphill,
geriux,
juanmaguitar and
fabiankaegy
as code owners
adamziel
force-pushed
the
update/remove-navigation-area
branch
from
881c474 to
b23987d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes the last mention of navigation-area block from the codebase.
The block was removed in #40645 and these few last places where it was still mentioned started causing trouble, e.g. in #41121.
Test plan
Confirm the CI checks are all nice and green.
cc @Mamaduka @getdave @scruffian @draganescu