-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break variables stylesheet up #964
Comments
Not exactly related to this, but worth noting that we're using these common stylesheets in |
Also semi-related, it looks like we're currently duplicating a lot of stuff across all of our Webpack builds (ref). In the development build, every single stylesheet (not just every Webpack target) gets all of the comments from |
I would also make most of the comments |
This PR splits out breakpoints and colors from the _variables.scss stylesheet, in a hope to fix #964. It also uses `//` for comments that should be eaten in compilation. Further improvements can probably be made if we find either the need for more variables in either of the current sections in _variables.scss, or if we can move some of those variables to live in context of the components that use them. As of now, though, the remaining variables don't feel like enough to split further, and the are used across many components.
Currently, the variables are in a single massive junk drawer of a stylesheet. Break them up for more context and simplicity. I would also keep the variables relevant to specific components with those specific components (most of the stuff in the Other section).
You may also look into a breakpoints mixin that avoids pixel overlap, but I trust @mtias work that out if needed.
The text was updated successfully, but these errors were encountered: