Split variables stylesheet into multiple #3804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR splits out breakpoints and colors from the _variables.scss stylesheet, in a hope to fix #964. It also uses `//` for comments that should be eaten in compilation. Further improvements can probably be made if we find either the need for more variables in either of the current sections in _variables.scss, or if we can move some of those variables to live in context of the components that use them. As of now, though, the remaining variables don't feel like enough to split further, and the are used across many components.
jasmussen
added
the
General Interface
jasmussen
requested review from
youknowriad,
MichaelArestad,
aduth and
jorgefilipecosta
…e for the breakpoint constants.
|
Hi @jasmussen, I added a new commit that updates our constants.js to import the breakpoint scss variables from the newly created file. Feel free change anything. I tested the changes and things look fine, and the variables are now better organized 👍 |
|
Thanks Jorge! Appreciate it. |
|
Nice work! Dig the changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits out breakpoints and colors from the _variables.scss stylesheet, in a hope to fix #964.
It also uses
//for comments that should be eaten in compilation.Further improvements can probably be made if we find either the need for more variables in either of the current sections in _variables.scss, or if we can move some of those variables to live in context of the components that use them. As of now, though, the remaining variables don't feel like enough to split further, and the are used across many components.