Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks if caption is empty in media lib and keeps the one written #19641

Merged
merged 2 commits into from
Feb 6, 2020
Merged

Checks if caption is empty in media lib and keeps the one written #19641

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4643556
checks if caption is empty in media lib and keeps the one written in …
draganescu Jan 14, 2020
45cc249
removes ALT from the solution
draganescu Jan 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions packages/block-library/src/image/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,15 +175,18 @@ export class ImageEdit extends Component {

let mediaAttributes = pickRelevantMediaFiles( media );

// If the current image is temporary but an alt or caption text was meanwhile written by the user,
// If the current image is temporary but an alt text was meanwhile written by the user,
// make sure the text is not overwritten.
if ( isTemporaryImage( id, url ) ) {
if ( alt ) {
mediaAttributes = omit( mediaAttributes, [ 'alt' ] );
}
if ( caption ) {
mediaAttributes = omit( mediaAttributes, [ 'caption' ] );
}
}

// If a caption text was meanwhile written by the user,
// make sure the text is not overwritten by empty captions
if ( caption && ! get( mediaAttributes, [ 'caption' ] ) ) {
mediaAttributes = omit( mediaAttributes, [ 'caption' ] );
}

let additionalAttributes;
Expand Down