Extract block draggable scroll behaviour into React hook #23444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Code Quality
|
Size Change: +61 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
6 tasks
youknowriad
reviewed
Jun 25, 2020
| const scrollParentY = useRef( null ); | ||
|
|
||
| const scrollEditorInterval = useRef( null ); | ||
| const blockElementId = `block-${ clientIds[ 0 ] }`; |
There was a problem hiding this comment.
I think right now we have a better way to get the block node from the tree using the "BlockNodes" context which means we can probably avoid this argument entirely.
There was a problem hiding this comment.
Oh yep, I recall seeing that. I've changed the code to use that.
I noticed as well that the code in the hook is fairly agnostic to any kind of drag/drop event, so I went with making the hook accept a dragElement and BlockDraggable now grabs the block's element from BlockNodes context to pass into the hook.
There was a problem hiding this comment.
I didn't see any issues when testing manually, but this change seems to be causing some issues with end-to-end tests.
I'll work on fixing it tomorrow.
youknowriad
approved these changes
Jun 25, 2020
This was referenced Jun 25, 2020
|
Can the same procedure be used here? Thanks for working on this, Dan! |
talldan
force-pushed
the
refactor/block-drag-scroll-behavior-into-hook
branch
from
fd06641 to
5c79b43
Compare
|
Tests are now passing, apart from PHP tests which seem to have started failing overnight. I can't see any merged PRs that might have caused it, so it's most likely an environment issue. Using admin privileges to merge this as it contains no PHP changes. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As mentioned in https://github.com/WordPress/gutenberg/pull/23082/files#r444178859, the new scroll behavior when dragging can be pretty neatly encapsulated into a React hook.
This PR moves the code into a hook, pretty much verbatim, with a few minor bits of renaming and updating of comments to meet coding standards.
How has this been tested?
master.Types of changes
Non-breaking code quality change
Checklist: