Try using a percentage based calculation for block drag scrolling velocity. #23448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Enhancement
6 tasks
|
Size Change: +64 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
6 tasks
|
Before:
After:
Thank you for making this PR! The scroll while dragging enhancement is great, but it was definitely a little aggressive. This balances it out, way better. 👍 👍 |
|
Nice! |
|
Very nice improvement. Thanks! |
talldan
force-pushed
the
try/block-drag-scroll-percentage-based
branch
from
2ad9d77 to
f6ab680
Compare
talldan
force-pushed
the
try/block-drag-scroll-percentage-based
branch
from
f6ab680 to
2aba546
Compare
gravityrail
requested changes
Jun 26, 2020
Comment on lines
+91
to
+97
| const dragDistance = Math.max( | ||
| offsetDragStartPosition - | ||
| offsetDragPosition - | ||
| SCROLL_INACTIVE_DISTANCE_PX, | ||
| 0 | ||
| ); | ||
| const distancePercentage = dragDistance / moveableDistance; |
There was a problem hiding this comment.
These lines appear to be duplicates of lines in the previous if-clause - is there a way to eliminate this duplication?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This tries an iteration on the behavior in #23082.
See also #23446 for an alternative.
It's based on the refactor to hooks in #23444, so the diff looks bigger than it is. That PR should ideally be merged first.
How does this differ from #23082
In #23082, when the user drags more than 50px the page starts scrolling in the direction they've dragged. The speed of the scrolling is based on how far the user drags.
Because the scroll speed is calculated using pixels, if the user starts dragging a block that's already near the top of the screen upwards there's a limit to the speed that the page can scroll. On the other hand, when dragging downwards from the top, very fast scroll speeds can be unexpectedly achieved due to the amount of space a user can drag into.
This PR makes the calculation percentage based. If the user drags to the top of the page the page scrolls at the same speed as if they dragged to the bottom, regardless of where they started dragging from.
How has this been tested?
Types of changes
Non-breaking enhancement
Checklist: