Mobile Release v1.43.0 #27566
Merged
Mobile Release v1.43.0 #27566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guarani
added
the
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.28 MB ℹ️ View Unchanged
|
3 tasks
…mpty for block formatting (#27583) * Treat a string that only contains the formatting marker as empty * Update changelog
guarani
force-pushed
the
rnmobile/release_1.43.0
branch
from
475a2ed to
8be01cb
Compare
cameronvoell
approved these changes
Dec 12, 2020
There was a problem hiding this comment.
Approved via wordpress-mobile/gutenberg-mobile#2874 (review)
|
The "End-to-End Tests / Admin - 3 (pull_request)" test is failing here, but it's also failing on |
|
@guarani these tests are flaky at times. What I normally do is re-run them so I can get all green checks and then I merge. I just did a re-run to see if it passes! |
|
Thanks for the re-run @jd-alexander, it looks like these are very flaky indeed 😅 |
It looks like @jd-alexander is away. @cameronvoell, would you be able to give a second opinion on whether this can be merged despite the failing test? |
|
@guarani It's very rare that we have to merge with failing tests in the gutenberg repo. Usually if there are CI failures on |
|
Looks like this is passing after @guarani merged in latest master 🎉 I'll go ahead and merge. |
Thanks for noticing! I'd looked on Thursday last week but had forgotten to check again to see if this had been resolved on
Awesome! I was second time lucky there (first time had resulted in another albeit different failing test). |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Release 1.43.0 of the react-native-editor and Gutenberg-Mobile.
For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#2874
Checklist: