[Mobile] - Fix crash when deleting a block #27683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geriux
added
[Type] Bug
2 tasks
|
Size Change: +4 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
Tug
approved these changes
Dec 11, 2020
Definitely, this is not the only case where we do this so we should investigate it. |
guarani
pushed a commit
that referenced
this pull request
Dec 11, 2020
Tug
pushed a commit
that referenced
this pull request
Dec 11, 2020
This was referenced Dec 11, 2020
3 tasks
cameronvoell
pushed a commit
that referenced
this pull request
Dec 23, 2020
* Release script: Update react-native-editor version to 1.43.0 * Release script: Update with changes from 'npm run core preios' * [Mobile] Treat a string that only contains the formatting marker as empty for block formatting (#27583) * Treat a string that only contains the formatting marker as empty * Update changelog * Mobile - Fix some cases where getBlockAttributes can be null when removing a block (#27683) * Updated CHANGELOG for release. * Removed this entry from this release since it's a hotfix. * Fix RN editor package.json indentation Co-authored-by: Chip <[email protected]> Co-authored-by: Gerardo Pacheco <[email protected]> Co-authored-by: Joel Dean <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gutenberg Mobile PR-> wordpress-mobile/gutenberg-mobile#2892Fixes wordpress-mobile/gutenberg-mobile#2886
Description
This PR fixes some cases where
getBlockAttributescan benull(for example when deleting a block) causing a crash on the mobile editor.How has this been tested?
On the WordPress app with metro running
Case 1
GroupblockHeadingblock with some text within theGroupblockHeadingblock and delete it using the toolbar menu (three dots) and then theRemove blockoptionCase 2
GroupblockButtonsblock within theGroupblockButtonand a linkButtonsblock and delete it using the toolbar menu (three dots) and then theRemove blockoptionCase 3
AboutlayoutCreate pageButtonblock Contact meRemove blockoptionScreenshots
Types of changes
Checklist: