Widget screens: set html block as freeform content handler #33164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Feature] Widgets Screen
getdave
requested review from
adamziel,
kevin940726,
noisysocks and
tellthemachines
as code owners
|
Size Change: +45 B (0%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
|
Might be a different issue entirely, but on my end these blocks get copied&pasted as text (list, list, and paragraph):
|
|
A-ha, it's the difference between using "cmd+c" and clicking "copy" in the context menu. Shouldn't the two behave the same though? |
adamziel
approved these changes
Jul 2, 2021
There was a problem hiding this comment.
This is a well-thought and safe fix, just what we need at the RC stage – great job @getdave 👍 . Let's keep the parser discussion going in parallel.
On, and the e2e failures are the same as in trunk so I'd say this one is good to go.
adamziel
added
the
Backport to WP 6.7 Beta/RC
draganescu
approved these changes
Jul 2, 2021
7 tasks
youknowriad
pushed a commit
that referenced
this pull request
Jul 5, 2021
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jul 6, 2021
youknowriad
pushed a commit
that referenced
this pull request
Jul 7, 2021
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a problem in the widgets screens whereby copy/pasting blocks would result in "missing" blocks being inserted into the editor canvas.
We do this by registering the
core/htmlblock as the default freeform content block to replace the defaultcore/freeformblock which we have de-registered for the Widgets screens to avoid allowing access to the Classic block interface.Explanation - why does this happen?
These missing blocks were generated by whitespace (inc. new lines) in between block definitions. For example:
The whitespace was being converted into the
core/missingblock due to thecore/freeformblock being de-registered in the Widgets editors. As thecore/freeformblock is set as the default freeform content handler this causes a bug.The reason for this was that the default block parser utilises the registered free form content handler to handle any random content (HTML) in between block definitions (including whitespace). As the free form content handler was de-registered the parser was falling back to the
core/missingblock - thus the errors on paste.For full info and context please see comments in #33097.
Also related: I have a proposal in #33136 to have the parser ignore and not try to create a freeform block for any content that is purely whitespace that it finds in between block definitions during parse.
Fixes #33097
How has this been tested?
core/missingblocks.Screenshots
Screen.Capture.on.2021-07-02.at.11-50-32.mov
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).