Add <CopyHandler> to WidgetAreasBlockEditorProvider #33166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
requested review from
draganescu,
kevin940726,
noisysocks,
talldan and
tellthemachines
as code owners
adamziel
added
[Feature] Widgets Screen
|
Size Change: +628 B (0%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
getdave
approved these changes
Jul 2, 2021
There was a problem hiding this comment.
Thanks for spotting and for such a quick followup.
This works as described:
Screen.Capture.on.2021-07-02.at.15-59-56.mov
In the video you'll see "missing blocks" when I paste but that's because this PR doesn't include my fix from #33164. If you rebase you'll get that but probably not required for approval.
|
Thanks @adamziel! |
noisysocks
added
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jul 5, 2021
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jul 6, 2021
youknowriad
pushed a commit
that referenced
this pull request
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This follows up on #33164 where I noticed that using "cmd+c" copies blocks as text whereas clicking "copy" in the context menu copies them as blocks. This PR wraps the widgets editor in
<CopyHandler>which restores the functionallty of cmd+c.How has this been tested?
This works best with #33164 applied, otherwise you'll see some error messages like "This block is missing". They can be ignored for the purposes of testing this specific PR.
Then repeat in the customizer (where you won't see the notice but the pasting should still work).
Types of changes
Bug fix (non-breaking change which fixes an issue)