-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scripts: Only use svgr/webpack in js files #34394
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walbo
added
[Type] Bug
An existing feature does not function as intended
[Tool] WP Scripts
/packages/scripts
labels
Aug 30, 2021
walbo
commented
Aug 30, 2021
walbo
force-pushed
the
fix/scripts-svgr
branch
from
August 31, 2021 18:17
4ff22ad
to
efaefeb
Compare
Size Change: +3 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
gziolo
approved these changes
Sep 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything works correctly with the updated configuration 👍🏻
I included a changelog entry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Only use svgr/webpack loader on js files and inline svg's from css files.
Fixes #34376
How has this been tested?
npx wp-create-block example --no-wp-scripts --template wp-block-directory-template
cd example
../node_modules/.bin/wp-scripts build
Screenshots
Types of changes
Bug fix
Checklist:
*.native.js
files for terms that need renaming or removal).