Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts: Only use svgr/webpack in js files #34394

Merged
merged 2 commits into from
Sep 2, 2021
Merged

Scripts: Only use svgr/webpack in js files #34394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efaefeb
Scripts: Only use svgr/webpack in js files
Aug 30, 2021
29092d0
Add CHHANGELOG entry
gziolo Sep 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/scripts/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Bug Fixes

- Bring back support for SVG files in CSS ([#34394](https://github.com/WordPress/gutenberg/pull/34394)). It wasn't correctly migrated when integrating webpack v5.

## 18.0.0 (2021-08-23)

### Breaking Changes
Expand Down
6 changes: 6 additions & 0 deletions packages/scripts/config/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,9 +184,15 @@ const config = {
},
{
test: /\.svg$/,
issuer: /\.jsx?$/,
use: [ '@svgr/webpack', 'url-loader' ],
type: 'javascript/auto',
},
{
test: /\.svg$/,
issuer: /\.(sc|sa|c)ss$/,
type: 'asset/inline',
gziolo marked this conversation as resolved.
Show resolved Hide resolved
},
{
test: /\.(bmp|png|jpe?g|gif)$/i,
type: 'asset/resource',
Expand Down