Gallery block: Remove the arbitrary alt text that is added to gallery images #35936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
the
[Block] Gallery
|
Size Change: -17 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Oct 26, 2021
There was a problem hiding this comment.
This tests well for me.
✅ v1 version of the block is unaffected
✅ An existing image-block based gallery that already has the "Image gallery image" alt text is unaffected after reloading and updating the post (so no block validation issues occur, and the alt text can be updated manually by clicking on the image block)
✅ Inserting a new gallery block with this PR applied, the alt text correctly gets picked up if it's set for the image in the media library, and the alt attribute is otherwise empty both within the editor and on the front end of the site. Setting the alt text manually within the image block in the editor still works as before
LGTM!
|
from accessibility standpoint, looks good to me; the arbitrary "image gallery image" is not helpful at all for accessibility; thanks for implementing. |
andrewserong
added
the
[Type] Bug
andrewserong
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the default alt text that is being added to gallery images with no alt text set based on this accessibility discussion, and this comment.
Testing