Fix permissions warning showing when inserting a navigation block #41862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
talldan
changed the title
|
Size Change: +430 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
|
@talldan good spot! It can be I'd change this fragment instead: To say: canUserUpdateNavigationMenu: canUpdate,
hasResolvedCanUserUpdateNavigationMenu:
ref && hasResolvedPermissions,
canUserDeleteNavigationMenu: canDelete,
hasResolvedCanUserDeleteNavigationMenu:
ref && hasResolvedPermissions, |
|
Thank you for the fix 👏 This seems like a regression. Should we add a test for it or do we want to avoid another potentially flaky test? |
getdave
approved these changes
Jun 22, 2022
If there is no menu then this should be falsey. In fact any call to the hook when the |
I'm migrating the tests to playwright at the moment, which is how I discovered the bug. I think it may be a bit tricky to write a test that catches this, as it's always difficult to check for the absence of something. We can try asserting
I think it depends on the question being asked. If it's "can I update or delete the current menu", then it should probably be
I'll go for something like this |
From what I remember the permissions are on a per post (menu) basis. So you can ask "can I update Menu X" but not "can I update all menus". I wish I'd written this down when I was working on the permissions feature of Nav block but turns out I didn't so I can't be 100% sure. I remember discussing with @spacedmonkey who has a very good understanding of the permissions system. I agree regarding |
This was referenced Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #41858, an incorrect permissions warning was showing
Why?
I think the main reason for the bug is that
canUserUpdateNavigationMenuisundefinedin this situation, so! canUserUpdateNavigationMenuresolves as truthy. One way to fix it might be to make this a more explicitcanUserUpdateNavigationMenu === false, but I don't know specifically if that'd be the right thing to do and what other values that variable can have.How?
This message should only show when the navigation block has an active navigation menu selected/assigned. There's no check for that, so I've added one (checking for the
refbeing truthy).Testing Instructions