Try: add a small radius to the multi selection style #44708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +8 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The multi selection style is rectangular:
The first commit in this branch adds a small block radius to the multi-selection overlay indicator, but notably leaves out the radius on blocks themselves:
The second commit, and what you'll see at the moment if you check out this branch, adds the radius also to blocks:
The reason this is a separate commit is that it adds an
overflow: hidden;to the selected block, whether one was there before or not. This feels appropriate given that it literally bounds the selection, however this would be good to test. For example, it appears to work fine with blocks that already have a stylistic radius applied:Testing Instructions
Please test selecting multiple blocks, including image, cover, and others, and observe the 2px radius.