Multi-select: Fix 1px indent. #44709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtias
approved these changes
Oct 5, 2022
|
Size Change: +5 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
|
@jasmussen should this be backported along with #44150? This seems like a bug fix, no? |
|
Thanks for checking in. I responded here as well. Whether #44150 gets backported or not, isn't crucial. It (and this along with it) could go in a minor release if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Followup to #44150, and might pair well with #44708.
Inline text selection aligns with the block toolbar:
But the new multi-select, which was designed to share DNA with inline selection but still be distinct for block level selection, did not. If you zoom in you can see it's indented on all 4 sides by 1px:
This PR fixes it so things line up:
Testing Instructions
Observe the multi select style, and that it aligns with block toolbar and inline text.