[Post Featured Image]: Fix some sizing issues #49641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +12 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
ntsekouras
added
[Block] Post Featured Image
|
Flaky tests detected in 8746c57. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4630662738
|
ntsekouras
force-pushed
the
try/fix-featured-image-sizing-issues
branch
from
8746c57 to
15bef96
Compare
ntsekouras
changed the title
ntsekouras
changed the title
jasmussen
approved these changes
Apr 20, 2023
|
@ntsekouras, this needs to be included in a minor WP release, correct? |
ntsekouras
added
the
Backport to WP Minor Release
|
@ntsekouras, I just noticed that after this change, the Feature Image block in post content takes up full width, even when alignment says "None." I believe that's due to this line change: const blockProps = useBlockProps( {
style: { width, height, aspectRatio, maxWidth: '100%' },
} );Screenshot
|
|
Good catch @Mamaduka ! I'll take a look tomorrow for a fix. |
This was referenced May 5, 2023
Mamaduka
removed
the
Backport to WP Minor Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves: #48988
This is a start to address some sizing issues in Post Featured Image block. There are more similar issues like: #48892, but we can iterate on fixing them.
Notes
This PR handles:
max-width:100%Testing instructions
For percentage width:
For overflowing images:
gridview.Before
before.mov
After
after.mov
🤖 Generated by Copilot at 15bef96