Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Post Featured Image]: Fix some sizing issues #49641

Merged
merged 1 commit into from
Apr 20, 2023
Merged

[Post Featured Image]: Fix some sizing issues #49641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/block-library/src/post-featured-image/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ export default function PostFeaturedImageEdit( {
} ) );

const blockProps = useBlockProps( {
style: { width, height, aspectRatio },
style: { width, height, aspectRatio, maxWidth: '100%' },
} );
const borderProps = useBorderProps( attributes );

Expand All @@ -110,7 +110,8 @@ export default function PostFeaturedImageEdit( {
) }
withIllustration={ true }
style={ {
...blockProps.style,
height: !! aspectRatio && '100%',
width: !! aspectRatio && '100%',
...borderProps.style,
} }
>
Expand Down Expand Up @@ -210,7 +211,7 @@ export default function PostFeaturedImageEdit( {
const label = __( 'Add a featured image' );
const imageStyles = {
...borderProps.style,
height: ( !! aspectRatio && '100%' ) || height,
height: aspectRatio ? '100%' : height,
width: !! aspectRatio && '100%',
objectFit: !! ( height || aspectRatio ) && scale,
};
Expand Down
2 changes: 1 addition & 1 deletion packages/block-library/src/post-featured-image/index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ function render_block_core_post_featured_image( $attributes, $content, $block )
if ( ! $height && ! $width && ! $aspect_ratio ) {
$wrapper_attributes = get_block_wrapper_attributes();
} else {
$wrapper_attributes = get_block_wrapper_attributes( array( 'style' => $aspect_ratio . $width . $height ) );
$wrapper_attributes = get_block_wrapper_attributes( array( 'style' => $aspect_ratio . $width . $height . 'max-width:100%;' ) );
}
return "<figure {$wrapper_attributes}>{$featured_image}</figure>";
}
Expand Down