[a11y] Fix: aria-haspop and aria-expanded attributes on the inserter button. #53692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Focus] Accessibility (a11y)
|
Size Change: +8 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
alexstine
reviewed
Aug 16, 2023
| @@ -148,6 +148,8 @@ function HeaderToolbar() { | |||
| icon={ plus } | |||
| label={ showIconLabels ? shortLabel : longLabel } | |||
| showTooltip={ ! showIconLabels } | |||
| aria-haspopup="true" | |||
| @@ -216,6 +216,8 @@ export default function HeaderEditMode() { | |||
| showIconLabels ? shortLabel : longLabel | |||
| } | |||
| showTooltip={ ! showIconLabels } | |||
| aria-haspopup="true" | |||
jorgefilipecosta
force-pushed
the
a11y/fix-aria-haspop-aria-expanded-attributes-on-inserter-button
branch
from
9a45793 to
f4c8671
Compare
|
Thank you @alexstine the feedback was applied. |
jorgefilipecosta
deleted the
a11y/fix-aria-haspop-aria-expanded-attributes-on-inserter-button
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #24796.
Currently, the inserter button opens an additional UI (inserter sidebar) but lacks aria-haspopup and aria-expanded tags. This PR resolves the issue.
Currently, the publish and sidebar button also open sidebars and already possesses these attributes, making this PR bring consistency to both elements.
Testing