[a11y] Fix: aria-haspop and aria-expanded attributes on list view button. #53693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Focus] Accessibility (a11y)
|
Size Change: +10 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
alexstine
reviewed
Aug 16, 2023
There was a problem hiding this comment.
This mostly looks good but please remove aria-haspopup. This is used incorrectly here.
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-haspopup
In ARIA, interactive menus, listboxes, trees, grids, and dialogs that appear on top of other content when triggered to appear are considered "popups".
| @@ -265,6 +265,8 @@ export default function HeaderEditMode() { | |||
| ? 'tertiary' | |||
| : undefined | |||
| } | |||
| aria-haspopup="true" | |||
| @@ -107,6 +107,8 @@ function HeaderToolbar() { | |||
| shortcut={ listViewShortcut } | |||
| showTooltip={ ! showIconLabels } | |||
| variant={ showIconLabels ? 'tertiary' : undefined } | |||
| aria-haspopup="true" | |||
jorgefilipecosta
force-pushed
the
a11y/fix-aria-haspop-aria-expanded-attributes-on-list-view-button
branch
from
d419080 to
3751564
Compare
|
Thank you for the review @alexstine, the feedback was applied. |
jorgefilipecosta
deleted the
a11y/fix-aria-haspop-aria-expanded-attributes-on-list-view-button
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #24796.
Currently, the list view button opens an additional UI (list view sidebar) but lacks aria-haspopup and aria-expanded tags. This PR addresses the issue.
Presently, the publish and sidebar buttons also trigger sidebars and already possess these attributes, ensuring this PR maintains uniformity across both elements.
A similar PR has been suggested for the inserter button at #53692.
Testing