-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPLAT-6218 Add sass task #305
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
f564b47
to
20bcf32
Compare
20bcf32
to
c0a97ea
Compare
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
library dart_dev.src.tasks.format.api; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
library dart_dev.src.tasks.format.api; | |
library dart_dev.src.tasks.sass.api; |
bool release = | ||
TaskCli.valueOf(releaseArgName, parsedArgs, config.sass.release); | ||
|
||
if (release && !parsedArgs['help']) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#nit I don't think the !parsedArgs['help']
is necessary here since it returns early above in that case
QA +1
@Workiva/release-management-p |
Adds a sass task which can be used like so:
pub run dart_dev sass
or
pub run dart_dev sass --watch
is what consumers would run locally - to compile stuff in whatever sourceDir the consumer has configured using the
expanded
output style. e.g. in wdesk_sdk’s case - inwdesk_sdk/tool/dev.dart
, there would be:config.sass.sourceDir = 'lib/';
then, in CI, consumers should run
pub run dart_dev sass -r
that command will run two things under the hood:
pub run dart_dev sass --check
and then if that does not fail:
pub run dart_dev sass --outputStyle=compressed
which will generate the minified output which will get bundled up with the pub artifact.