Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPLAT-6218 Add sass task #305

Merged
merged 1 commit into from
Jun 25, 2019
Merged

CPLAT-6218 Add sass task #305

merged 1 commit into from
Jun 25, 2019

Conversation

aaronlademann-wf
Copy link
Contributor

@aaronlademann-wf aaronlademann-wf commented Jun 20, 2019

Adds a sass task which can be used like so:

pub run dart_dev sass

or

pub run dart_dev sass --watch

is what consumers would run locally - to compile stuff in whatever sourceDir the consumer has configured using the expanded output style. e.g. in wdesk_sdk’s case - in wdesk_sdk/tool/dev.dart, there would be:

config.sass.sourceDir = 'lib/';

then, in CI, consumers should run

pub run dart_dev sass -r

that command will run two things under the hood:

pub run dart_dev sass --check

and then if that does not fail:

pub run dart_dev sass --outputStyle=compressed

which will generate the minified output which will get bundled up with the pub artifact.

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@aaronlademann-wf aaronlademann-wf changed the title [WIP] Add sass task Add sass task Jun 21, 2019
@aaronlademann-wf aaronlademann-wf marked this pull request as ready for review June 21, 2019 20:52
@aaronlademann-wf aaronlademann-wf force-pushed the add-sass-task branch 2 times, most recently from f564b47 to 20bcf32 Compare June 24, 2019 20:36
@aaronlademann-wf aaronlademann-wf changed the title Add sass task CPLAT-6218 Add sass task Jun 24, 2019
// See the License for the specific language governing permissions and
// limitations under the License.

library dart_dev.src.tasks.format.api;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
library dart_dev.src.tasks.format.api;
library dart_dev.src.tasks.sass.api;

bool release =
TaskCli.valueOf(releaseArgName, parsedArgs, config.sass.release);

if (release && !parsedArgs['help']) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#nit I don't think the !parsedArgs['help'] is necessary here since it returns early above in that case

@evanweible-wf
Copy link
Contributor

QA +1

  • CI passes
  • Tested in wdesk_sdk (normal run, --watch, and -r)

@Workiva/release-management-p

@rmconsole3-wf rmconsole3-wf merged commit af0c469 into master Jun 25, 2019
@rmconsole3-wf rmconsole3-wf deleted the add-sass-task branch June 25, 2019 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants