Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPLAT-6212: Add dedicated sass entrypoint #123

Merged
merged 3 commits into from
Jun 24, 2019
Merged

CPLAT-6212: Add dedicated sass entrypoint #123

merged 3 commits into from
Jun 24, 2019

Conversation

aaronlademann-wf
Copy link
Contributor

@aaronlademann-wf aaronlademann-wf commented Jun 21, 2019 •
edited by charliekump-wf
Loading

CPLAT-6212

Issue Status

Exposes some constants / entrypoints needed for Workiva/dart_dev#305

@aaronlademann-wf
Add a separate sass entrypoint
5b9a0fc
@aaronlademann-wf
LOG
4df0177
@aaronlademann-wf
Expose main compile_sass entrypoint
53b16a9 
+ So that consumers like dart_dev don’t have to require that their consumers have a non-transitive dependency on of w_common in order to use their pub script that proxies ours.
@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@aaronlademann-wf aaronlademann-wf mentioned this pull request Jun 21, 2019
Merged
@rmconsole4-wk rmconsole4-wk changed the title Add dedicated sass entrypoint CPLAT-6212 Add dedicated sass entrypoint Jun 24, 2019
@charliekump-wf charliekump-wf changed the title CPLAT-6212 Add dedicated sass entrypoint CPLAT-6212: Add dedicated sass entrypoint Jun 24, 2019
@aaronlademann-wf
Copy link
Contributor Author

@Workiva/release-management-pp

@rm-astro-wf rm-astro-wf merged commit f4f523a into master Jun 24, 2019
@rm-astro-wf rm-astro-wf deleted the dedicated-sass-entrypoint branch June 24, 2019 20:22
@rmconsole-readonly-wk rmconsole-readonly-wk mentioned this pull request Jun 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanweible-wf evanweible-wf evanweible-wf approved these changes

Assignees
No one assigned
Labels
Merge Requirements Met RM Ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aaronlademann-wf @aviary3-wk @evanweible-wf @rmconsole-wf @rm-astro-wf