Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CONTRIBUTING.md #3922

Closed
wants to merge 1 commit into from
Closed

Create CONTRIBUTING.md #3922

wants to merge 1 commit into from

Conversation

sneh19337
Copy link

Adding Contributing.md

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

Adding Contributing.md
@nbougalis
Copy link
Contributor

Thank you for creating CONTRIBUTING.md. I think that this is a great first step, and will be leaving some comments later.

@wojake
Copy link
Collaborator

wojake commented Oct 5, 2021

I think @nbougalis needs to review and approve this so a CONTRIBUTING.md is available in the repo.
The file seems useful for developers looking to contribute, perhaps make it look better as it looks messy as of now.

@wojake wojake mentioned this pull request Oct 15, 2021
7 tasks
wojake added a commit to wojake/rippled that referenced this pull request Oct 15, 2021
Better phrasing, added sources, structured the file | XRPLF#3922
@wojake wojake mentioned this pull request Oct 15, 2021
7 tasks
@intelliot
Copy link
Collaborator

Closing in favor of #3955 which is better (both in formatting and content) - feel free to add / contribute over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants