Skip to content
This repository has been archived by the owner on Aug 11, 2024. It is now read-only.

Ensure we set the scene in the build settings if no scenes are available #257

Merged
merged 2 commits into from
Jul 27, 2019

Conversation

StephenHodgson
Copy link
Contributor

@StephenHodgson StephenHodgson commented Jul 26, 2019

XRTK - Mixed Reality Toolkit Change Request

Overview

When no scenes are in the editor build settings the preferences window wasn't allowing me to set the scene I wanted in the XRTK start scene object inspector. This PR should fix this if no scenes are present.

This PR may also fix #174 but needs to be tested.

Target of the change:

Is this enhancement for:

  • Core (core framework, interfaces and definitions)

@StephenHodgson StephenHodgson added Bug Something isn't working Ready for review PR finished primary development, open for review labels Jul 26, 2019
Copy link
Contributor

@SimonDarksideJ SimonDarksideJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't fix the Unity crash bug, but improves general feel.

@SimonDarksideJ SimonDarksideJ merged commit 39a6279 into development Jul 27, 2019
@SimonDarksideJ SimonDarksideJ deleted the dev/start-scene-fix branch July 27, 2019 14:43
XRTK-Build-Bot pushed a commit that referenced this pull request Aug 8, 2019
…ble (#257)

* Ensure we set the scene in the build settings if no scenes are available

* int equality
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something isn't working Ready for review PR finished primary development, open for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants