This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Camera System Refactor #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenHodgson
added
Breaking Change
In Progress
This was referenced Apr 11, 2020
StephenHodgson
commented
Apr 11, 2020
…nitialization Fixed platforms so they only return true outside of the editor
Merged
StephenHodgson
added
Ready for review
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This PR needs a lot of cleaning up as it contains so many different changes unrelated to the Camera System update |
XRTK-Core/Packages/com.xrtk.core/Interfaces/CameraSystem/IMixedRealityCameraSystem.cs
Show resolved
Hide resolved
FejZa
previously approved these changes
Apr 23, 2020
XRTK-Core/Packages/com.xrtk.core/Definitions/CameraSystem/MixedRealityCameraSystemProfile.cs
Outdated
Show resolved
Hide resolved
XRTK-Core/Packages/com.xrtk.core/Definitions/CameraSystem/MixedRealityCameraSystemProfile.cs
Outdated
Show resolved
Hide resolved
XRTK-Core/Packages/com.xrtk.core/Interfaces/CameraSystem/IMixedRealityCameraDataProvider.cs
Show resolved
Hide resolved
| /// </summary> | ||
| float DefaultHeadHeight { get; } | ||
| /// <param name="dataProvider"></param> | ||
| void RegisterCameraDataProvider(IMixedRealityCameraDataProvider dataProvider); |
There was a problem hiding this comment.
I am a bit surprised here. The way you implemented this reminds me a bit of how I did the diagnostics system and hands back then. But then we changed it and decided to not have custom registries in the systems for consistency with the how it's setup in other modules. What made you change your mind here?
There was a problem hiding this comment.
I think it was mainly bc of the event handlers we are using.
We're not using event handling for anything in the camera system afaik.
There was a problem hiding this comment.
Idk I can go either way with this.
I'll look back at the Input and Diagnostics systems to see if we can do something similar.
The biggest difference is that the Diagnostics and Input Systems are Event Systems, while the Camera System is not. No one is listening for events here.
XRTK-Core/Packages/com.xrtk.core/Providers/CameraSystem/BaseCameraDataProvider.cs
Outdated
Show resolved
Hide resolved
cleaned up profile value assignments cleaned up magic numbers
StephenHodgson
commented
Apr 23, 2020
...ages/com.xrtk.core/Inspectors/Profiles/BaseMixedRealityCameraDataProviderProfileInspector.cs
Outdated
Show resolved
Hide resolved
…RealityCameraDataProviderProfileInspector.cs
StephenHodgson
commented
Apr 23, 2020
...ckages/com.xrtk.core/Definitions/Controllers/Simulation/Hands/SimulatedHandControllerPose.cs
Outdated
Show resolved
Hide resolved
StephenHodgson
commented
Apr 23, 2020
...ckages/com.xrtk.core/Definitions/Controllers/Simulation/Hands/SimulatedHandControllerPose.cs
Outdated
Show resolved
Hide resolved
StephenHodgson
commented
Apr 23, 2020
...ages/com.xrtk.core/Inspectors/Profiles/BaseMixedRealityCameraDataProviderProfileInspector.cs
Outdated
Show resolved
Hide resolved
StephenHodgson
commented
Apr 23, 2020
XRTK-Core/Packages/com.xrtk.core/Providers/Controllers/BaseController.cs
Outdated
Show resolved
Hide resolved
StephenHodgson
commented
Apr 23, 2020
XRTK-Core/Packages/com.xrtk.core/Providers/Controllers/BaseController.cs
Outdated
Show resolved
Hide resolved
StephenHodgson
commented
Apr 23, 2020
XRTK-Core/Packages/com.xrtk.core/Providers/Controllers/BaseControllerDataProvider.cs
Outdated
Show resolved
Hide resolved
StephenHodgson
commented
Apr 23, 2020
...ore/Packages/com.xrtk.core/Providers/Controllers/Simulation/Hands/SimulatedHandController.cs
Outdated
Show resolved
Hide resolved
StephenHodgson
commented
Apr 23, 2020
...ore/Packages/com.xrtk.core/Providers/Controllers/Simulation/Hands/SimulatedHandController.cs
Outdated
Show resolved
Hide resolved
StephenHodgson
commented
Apr 23, 2020
XRTK-Core/Packages/com.xrtk.core/Services/BoundarySystem/MixedRealityBoundarySystem.cs
Outdated
Show resolved
Hide resolved
StephenHodgson
commented
Apr 23, 2020
XRTK-Core/Packages/com.xrtk.core/Services/BoundarySystem/MixedRealityBoundarySystem.cs
Outdated
Show resolved
Hide resolved
StephenHodgson
commented
Apr 23, 2020
XRTK-Core/Packages/com.xrtk.core/Services/BoundarySystem/MixedRealityBoundarySystem.cs
Outdated
Show resolved
Hide resolved
StephenHodgson
commented
Apr 23, 2020
XRTK-Core/Packages/com.xrtk.core/Services/BoundarySystem/MixedRealityBoundarySystem.cs
Outdated
Show resolved
Hide resolved
StephenHodgson
commented
Apr 23, 2020
XRTK-Core/Packages/com.xrtk.core/Services/BoundarySystem/MixedRealityBoundarySystem.cs
Outdated
Show resolved
Hide resolved
StephenHodgson
commented
Apr 23, 2020
XRTK-Core/Packages/com.xrtk.core/Services/DiagnosticsSystem/MixedRealityDiagnosticsSystem.cs
Outdated
Show resolved
Hide resolved
StephenHodgson
commented
Apr 23, 2020
...Packages/com.xrtk.core/Services/SpatialAwarenessSystem/MixedRealitySpatialAwarenessSystem.cs
Outdated
Show resolved
Hide resolved
StephenHodgson
commented
Apr 23, 2020
FejZa
approved these changes
Apr 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Change Request
Overview
Refactored the Camera System to have per platform data providers and settings on top of the global ones.
Target of the change:
Is this enhancement for:
Breaking Changes:
Are there any breaking changes included in this change that would prevent or cause issue for existing projects.
IMixedRealityCameraSystemIMixedRealityDataProvider, all of the original logic in the camera system was moved into theBaseCameraDataProviderclass.Submodule Changes
XRTK/com.xrtk.sdk#153
XRTK/com.xrtk.oculus#54
XRTK/com.xrtk.lumin#60
XRTK/com.xrtk.wmr#66
TODO
Tests should also include moving the playspace to ensure that both spatial awareness and teleportation is keeping the tracked objects in sync with the playspace.