This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Added configuration foldout to all service configuration profiles #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iguration expects
StephenHodgson
added
the
Ready for review
FejZa
approved these changes
Apr 21, 2020
| serializedObject.Update(); | ||
| EditorGUILayout.Space(); | ||
| configurationList.DoLayoutList(); | ||
| showConfigurationFoldout = EditorGUILayout.Foldout(showConfigurationFoldout, new GUIContent($"{ServiceConstraint.Name} Configuration Options"), true); |
There was a problem hiding this comment.
I think this can be cached as well.
There was a problem hiding this comment.
Can it? I'm not confident the service constraint is populated in the constructor
| serializedObject.Update(); | ||
| EditorGUILayout.Space(); | ||
| configurationList.DoLayoutList(); | ||
| showConfigurationFoldout = EditorGUILayout.Foldout(showConfigurationFoldout, new GUIContent($"{ServiceConstraint.Name} Configuration Options"), true); |
There was a problem hiding this comment.
Can we use the "EditorGUILayoutExtensions.FoldoutWithBoldLabel" here? To gradually update all the inspectors to use it?
There was a problem hiding this comment.
We do use it in the rolled up branches. It's just that you didn't commit just that change to the development branch. (We could have you pull it out but that's up to you)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Change Request
Overview