[RWRoute] Further cleanup #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
…exists Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
…eSource() Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
eddieh-xlnx
commented
Sep 26, 2024
eddieh-xlnx
commented
Sep 26, 2024
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: eddieh-xlnx <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
This reverts commit 12348ce. Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]> As it seems to be an expensive look up in the hot path for little gain
Signed-off-by: Eddie Hung <[email protected]>
Signed-off-by: Eddie Hung <[email protected]>
eddieh-xlnx
force-pushed
the
rwroute_cleanup
branch
from
b7d9735 to
8074703
Compare
clavin-xlnx
approved these changes
Sep 26, 2024
| @@ -498,4 +490,25 @@ public void setAllTargets(RWRoute.ConnectionState state) { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| protected Pair<SitePinInst,RouteNode> getOrCreateAlternateSource(RouteNodeGraph routingGraph) { | |||
There was a problem hiding this comment.
What does this method intend to do in the context of Versal? In UltraScale+ there is only one other option, but there might be a preference of one vs another given the choices in Versal and the context. Not saying this has to implement Versal, but we should be aware of the soon-to-be-added context.
There was a problem hiding this comment.
Let's clean up UltraScale/UltraScale+ before we consider Versal. I think there's some other RapidWright infrastructure upgrades that needs to happen before Versal's alternate sources can really be captured.
eddieh-xlnx
commented
Sep 26, 2024
Signed-off-by: eddieh-xlnx <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RWRouteto not check for sink routability anymorePartialRouterto only check sink routability after all nodes have been preservedRWRoute.handleUnroutableConnection()to abandon connections that are guaranteed to be unroutable since the bounding box is never enlarged (nor any nets be unpreserved, in the case ofPartialRouter)RWRouteto not pre-emptively set up the second source; do so only when needed inRWRoute.swapOutputPin()or when recovering partially routed nets inPartialRouter