-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RWRoute] Further cleanup #1070
Merged
Merged
Changes from all commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
f405faf
[RWRoute] Remove unnecessary overrides
eddieh-xlnx 930aa99
[Connection] getNodes() to return empty list not null
eddieh-xlnx e6f9605
Improve TestRWRoute.testNonTimingDrivenPartialRouting()
eddieh-xlnx c1fcf1f
[PartialRouter] isAccessible() to always allow preserved nets
eddieh-xlnx d92ab01
[PartialRouter] Abandon unrouteable connections
eddieh-xlnx aca84f2
[PartialRouter] Check sink routability after preserveAsync()
eddieh-xlnx 5fd643b
Tidy up
eddieh-xlnx 4c1048e
[RWRoute] Lazy source swapping
eddieh-xlnx 34badd7
Add messaging
eddieh-xlnx 7181115
Try removing stashedPrev
eddieh-xlnx 91aa14b
Missing !
eddieh-xlnx 7091c8a
Fix abandoning connections for unpreservable
eddieh-xlnx 0698be2
RWRoute to not pre-emptively set up second source
eddieh-xlnx 3bce2ee
Refactor output pin swapping/connection abandonment
eddieh-xlnx b0de24b
Abandon connections with message, and remove from sorted
eddieh-xlnx b8ad542
Fix for nets with direct and indirect connections
eddieh-xlnx 9857956
Refactor into RWRoute.saveRoutingSource()
eddieh-xlnx ce6edd8
Refactor
eddieh-xlnx 9e64488
Remove stale comment
eddieh-xlnx f6e4a77
Cache result of finding alt source pins
eddieh-xlnx c233041
Inline trivial method
eddieh-xlnx a3d6dbc
NetWrapper.getAltSource() to compute altSourceRnode when pin already …
eddieh-xlnx ac6f796
Allow promotion for PINBOUNCE to PINFEED_I
eddieh-xlnx 60fbb6e
Fix assertion in RWRoute.push()
eddieh-xlnx c5342e0
Fix broken assumptions
eddieh-xlnx 65db026
Move RWRoute.setupAlternateSource() to Connection.getOrCreateAlternat…
eddieh-xlnx 6b8eb10
Fix RWRoute.saveRouting() return value
eddieh-xlnx 47af493
Consistency
eddieh-xlnx 3360069
Reverse whitespace change
eddieh-xlnx 4b11044
Bump copyright
eddieh-xlnx de4504f
Direct connection if sink cannot be projected
eddieh-xlnx 39866ca
Apply suggestions from code review
eddieh-xlnx 94ce54c
Merge remote-tracking branch 'upstream/master' into rwroute_cleanup
eddieh-xlnx 6ef43cb
Set random seed for Test.testNonTimingDrivenPartialRouting()
eddieh-xlnx 3611209
Condition to avoid extra work
eddieh-xlnx 6caa610
Move getPreservedNet() call to after
eddieh-xlnx a83acd4
Remove unused method
eddieh-xlnx 12348ce
Try AtomicReferenceArray instead of ConcurrentHashMap
eddieh-xlnx dcfe994
Revert RapidWrightDCP submodule
eddieh-xlnx cb57eb2
Revert "Try AtomicReferenceArray instead of ConcurrentHashMap"
eddieh-xlnx f4ab6dc
Revert [PartialRouter] isAccessible() to always allow preserved nets
eddieh-xlnx aed25d3
Add TODO
eddieh-xlnx 8074703
Add PartialRouter.saveRouting() override
eddieh-xlnx aee5bc0
Merge branch '2024.1.3' into rwroute_cleanup
eddieh-xlnx d006b61
Apply suggestions from code review
eddieh-xlnx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this method intend to do in the context of Versal? In UltraScale+ there is only one other option, but there might be a preference of one vs another given the choices in Versal and the context. Not saying this has to implement Versal, but we should be aware of the soon-to-be-added context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's clean up UltraScale/UltraScale+ before we consider Versal. I think there's some other RapidWright infrastructure upgrades that needs to happen before Versal's alternate sources can really be captured.