apache#2450 update code by comments

Yangxuhao123 · Mar 11, 2024 · c7767ed · c7767ed
1 parent 805b291
commit c7767ed
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 14 deletions.
diff --git a/integration-test/src/test/java/com/datastrato/gravitino/integration/test/spark/SparkIT.java b/integration-test/src/test/java/com/datastrato/gravitino/integration/test/spark/SparkIT.java
@@ -299,8 +299,8 @@ void testAlterTableAddAndDeleteColumn() {
   }
 
   @Test
-  void testAlterTableUpdateColumn() {
-    String tableName = "test_update_column";
+  void testAlterTableRenameColumn() {
+    String tableName = "test_rename_column";
     dropTableIfExists(tableName);
     List<SparkColumnInfo> simpleTableColumns = getSimpleTableColumn();
     createSimpleTable(tableName);
@@ -309,7 +309,9 @@ void testAlterTableUpdateColumn() {
     String oldColumnName = "age";
     String newColumnName = "newAge";
 
-    sql(String.format("ALTER TABLE %S RENAME COLUMNS %S TO %S", tableName, oldColumnName, newColumnName));
+    sql(
+        String.format(
+            "ALTER TABLE %S RENAME COLUMNS %S TO %S", tableName, oldColumnName, newColumnName));
     ArrayList<SparkColumnInfo> renameColumns = new ArrayList<>(simpleTableColumns);
     renameColumns.remove(SparkColumnInfo.of("age", DataTypes.IntegerType, null));
     renameColumns.add(SparkColumnInfo.of("newAge", DataTypes.IntegerType, null));

diff --git a/...ctor/src/main/java/com/datastrato/gravitino/spark/connector/catalog/GravitinoCatalog.java b/...ctor/src/main/java/com/datastrato/gravitino/spark/connector/catalog/GravitinoCatalog.java
@@ -373,10 +373,10 @@ static com.datastrato.gravitino.rel.TableChange transformTableChange(TableChange
       TableChange.DeleteColumn deleteColumn = (TableChange.DeleteColumn) change;
       return com.datastrato.gravitino.rel.TableChange.deleteColumn(
           deleteColumn.fieldNames(), deleteColumn.ifExists());
-    } else if (change instanceof TableChange.RenameColumn){
+    } else if (change instanceof TableChange.RenameColumn) {
       TableChange.RenameColumn renameColumn = (TableChange.RenameColumn) change;
-      return com.datastrato.gravitino.rel.TableChange.renameColumn(renameColumn.fieldNames(),
-              renameColumn.newName());
+      return com.datastrato.gravitino.rel.TableChange.renameColumn(
+          renameColumn.fieldNames(), renameColumn.newName());
     } else {
       throw new UnsupportedOperationException(
           String.format("Unsupported table change %s", change.getClass().getName()));

diff --git a/.../test/java/com/datastrato/gravitino/spark/connector/catalog/TestTransformTableChange.java b/.../test/java/com/datastrato/gravitino/spark/connector/catalog/TestTransformTableChange.java
@@ -40,22 +40,22 @@ void testTransformRemoveProperty() {
   }
 
   @Test
-  void testTransformRenameColumn(){
-    String[] oldFiledsName = new String[]{"default_name"};
+  void testTransformRenameColumn() {
+    String[] oldFiledsName = new String[] {"default_name"};
     String newFiledName = "new_name";
 
     TableChange.RenameColumn sparkRenameColumn =
-            (TableChange.RenameColumn) TableChange.renameColumn(oldFiledsName,newFiledName);
+        (TableChange.RenameColumn) TableChange.renameColumn(oldFiledsName, newFiledName);
     com.datastrato.gravitino.rel.TableChange gravitinoChange =
-            GravitinoCatalog.transformTableChange(sparkRenameColumn);
+        GravitinoCatalog.transformTableChange(sparkRenameColumn);
 
     Assertions.assertTrue(
-            gravitinoChange instanceof com.datastrato.gravitino.rel.TableChange.RenameColumn);
+        gravitinoChange instanceof com.datastrato.gravitino.rel.TableChange.RenameColumn);
     com.datastrato.gravitino.rel.TableChange.RenameColumn gravitinoRenameColumn =
-            (com.datastrato.gravitino.rel.TableChange.RenameColumn) gravitinoChange;
+        (com.datastrato.gravitino.rel.TableChange.RenameColumn) gravitinoChange;
 
-    Assertions.assertEquals("default_name",gravitinoRenameColumn.getFieldName()[0]);
-    Assertions.assertEquals("new_name",gravitinoRenameColumn.getNewName());
+    Assertions.assertEquals(oldFiledsName, gravitinoRenameCeolumn.getFieldName());
+    Assertions.assertEquals(newFiledName, gravitinoRenameColumn.getNewName());
   }
 
   @Test