Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Subtask] add RenameColumn support for spark-connector #2450

Closed
FANNG1 opened this issue Mar 7, 2024 · 1 comment · Fixed by #2507
Closed

[Subtask] add RenameColumn support for spark-connector #2450

FANNG1 opened this issue Mar 7, 2024 · 1 comment · Fixed by #2507
Assignees
@Yangxuhao123
Labels
good first issue Good for newcomers subtask Subtasks of umbrella issue
Milestone
Gravitino 0.5.0

Comments

@FANNG1
Copy link
Contributor

FANNG1 commented Mar 7, 2024

Describe the subtask

Describe the subtask

please add related code to com.datastrato.gravitino.spark.catalogGravitinoCatalog.java, transfrom Spark TableChange to Gravitino TableChange, you could refer to renameTable implement

  public Table alterTable(Identifier ident, TableChange... changes) throws NoSuchTableException {
    throw new NotSupportedException("Doesn't support altering table for now");
  }

Related Spark SQL should add to SparkIT.java, please refer https://spark.apache.org/docs/latest/sql-ref-syntax-ddl-alter-table.html

Parent issue

#1227
@FANNG1 FANNG1 added subtask Subtasks of umbrella issue good first issue Good for newcomers labels Mar 7, 2024
@Yangxuhao123
Copy link
Contributor

@FANNG1 i will work on this issue.

@jerryshao jerryshao added this to the Gravitino 0.5.0 milestone Mar 7, 2024
Yangxuhao123 pushed a commit to Yangxuhao123/gravitino that referenced this issue Mar 11, 2024
apache#2450 add RenameColumn support for spark-connector
e7a8478
Yangxuhao123 pushed a commit to Yangxuhao123/gravitino that referenced this issue Mar 11, 2024
apache#2450 fixed code format
805b291
Yangxuhao123 pushed a commit to Yangxuhao123/gravitino that referenced this issue Mar 11, 2024
apache#2450 update code by comments
c7767ed
Yangxuhao123 pushed a commit to Yangxuhao123/gravitino that referenced this issue Mar 12, 2024
apache#2450 fix spelling error and better variable name
9e393d8
Yangxuhao123 pushed a commit to Yangxuhao123/gravitino that referenced this issue Mar 12, 2024
[apache#2450] add RenameColumn support for spark-connector
d4c1815
Yangxuhao123 pushed a commit to Yangxuhao123/gravitino that referenced this issue Mar 12, 2024
apache#2450 fix spelling error and better variable name
a0c5626
Yangxuhao123 pushed a commit to Yangxuhao123/gravitino that referenced this issue Mar 12, 2024
apache#2450 rebase code
e05ae4c
Yangxuhao123 pushed a commit to Yangxuhao123/gravitino that referenced this issue Mar 12, 2024
apache#2450 update columns to column
e2090d9
Yangxuhao123 pushed a commit to Yangxuhao123/gravitino that referenced this issue Mar 12, 2024
apache#2450 update unit test by comments
28e3cd3
Yangxuhao123 pushed a commit to Yangxuhao123/gravitino that referenced this issue Mar 12, 2024
apache#2450 fix code
7e4603a
Yangxuhao123 pushed a commit to Yangxuhao123/gravitino that referenced this issue Mar 12, 2024
[apache#2450] add RenameColumn support for spark-connector
8849679
Yangxuhao123 pushed a commit to Yangxuhao123/gravitino that referenced this issue Mar 12, 2024
apache#2450 fix code
c85ad11
FANNG1 pushed a commit that referenced this issue Mar 12, 2024
@Yangxuhao123
#2450 add RenameColumn support for spark-connector (#2507)
0834b97 
### What changes were proposed in this pull request?

support rename table column for spark-connector in RenameColumnCommand.

### Why are the changes needed?

Fix: # 2450

### Does this PR introduce _any_ user-facing change?

`alter table default_catalog.default_db.default_table rename age to
new_age;`

### How was this patch tested?
write new unit tests.

---------

Co-authored-by: ryan02.yang <[email protected]>
@FANNG1 FANNG1 mentioned this issue Mar 13, 2024
Merged
@FANNG1 FANNG1 closed this as completed Mar 13, 2024
Yangxuhao123 pushed a commit to Yangxuhao123/gravitino that referenced this issue Mar 14, 2024
apache#2450 fix conflict
6451a5e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yangxuhao123 Yangxuhao123

Labels
good first issue Good for newcomers subtask Subtasks of umbrella issue
Projects
None yet
Milestone
Gravitino 0.5.0
Development

Successfully merging a pull request may close this issue.

#2450 add RenameColumn support for spark-connector Yangxuhao123/gravitino
3 participants
@jerryshao @FANNG1 @Yangxuhao123