Skip to content

Commit

Permalink
Merge pull request #63 from topiaruss/patch-1
Browse files Browse the repository at this point in the history
Force .perform_logging to bool
  • Loading branch information
kaisen authored Nov 29, 2017
2 parents 7937ca8 + ccecc6c commit 70c58b1
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion py_zipkin/zipkin.py
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,8 @@ def start(self):
self.do_pop_attrs = False
# If zipkin_attrs are passed in or this span is doing its own sampling,
# it will need to actually log spans at __exit__.
self.perform_logging = self.zipkin_attrs or self.sample_rate is not None
self.perform_logging = bool(self.zipkin_attrs or
self.sample_rate is not None)
report_root_timestamp = False

if self.sample_rate is not None:
Expand Down

0 comments on commit 70c58b1

Please sign in to comment.