-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force .perform_logging to bool #63
Conversation
3 similar comments
3 similar comments
3 similar comments
Thanks for the PR! I'm probably going to merge this, but I'm curious: is this fixing a bug? From what I see, |
I think you are probably right. And I'm not aware of a bug. |
4 similar comments
Merging anyway. Explicit is good :) |
Well done. I'm enjoying using it. Thanks! |
Without this change, perform_logging ends up with the the value of any passed zipkin_attrs.