Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force .perform_logging to bool #63

Merged
merged 4 commits into from
Nov 29, 2017
Merged

Force .perform_logging to bool #63

merged 4 commits into from
Nov 29, 2017

Conversation

topiaruss
Copy link
Contributor

Without this change, perform_logging ends up with the the value of any passed zipkin_attrs.

@coveralls
Copy link

coveralls commented Nov 28, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 34fe76f on topiaruss:patch-1 into 7937ca8 on Yelp:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d68957f on topiaruss:patch-1 into 7937ca8 on Yelp:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d68957f on topiaruss:patch-1 into 7937ca8 on Yelp:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d68957f on topiaruss:patch-1 into 7937ca8 on Yelp:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d68957f on topiaruss:patch-1 into 7937ca8 on Yelp:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 066d141 on topiaruss:patch-1 into 7937ca8 on Yelp:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 066d141 on topiaruss:patch-1 into 7937ca8 on Yelp:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 066d141 on topiaruss:patch-1 into 7937ca8 on Yelp:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 066d141 on topiaruss:patch-1 into 7937ca8 on Yelp:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ccecc6c on topiaruss:patch-1 into 7937ca8 on Yelp:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ccecc6c on topiaruss:patch-1 into 7937ca8 on Yelp:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ccecc6c on topiaruss:patch-1 into 7937ca8 on Yelp:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ccecc6c on topiaruss:patch-1 into 7937ca8 on Yelp:master.

@kaisen
Copy link
Member

kaisen commented Nov 28, 2017

Thanks for the PR! I'm probably going to merge this, but I'm curious: is this fixing a bug? From what I see, self.perform_logging is only evaluated for truthiness, so the code should work regardless of the actual type of self.perform_logging.

@topiaruss
Copy link
Contributor Author

I think you are probably right. And I'm not aware of a bug.
I was debugging an issue and surprised to see a list in what looked like a boolean field.
Just cleaning it up, in passing.

@topiaruss topiaruss closed this Nov 28, 2017
@topiaruss topiaruss reopened this Nov 28, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ccecc6c on topiaruss:patch-1 into 7937ca8 on Yelp:master.

4 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ccecc6c on topiaruss:patch-1 into 7937ca8 on Yelp:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ccecc6c on topiaruss:patch-1 into 7937ca8 on Yelp:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ccecc6c on topiaruss:patch-1 into 7937ca8 on Yelp:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ccecc6c on topiaruss:patch-1 into 7937ca8 on Yelp:master.

@kaisen kaisen merged commit 70c58b1 into Yelp:master Nov 29, 2017
@kaisen
Copy link
Member

kaisen commented Nov 29, 2017

Merging anyway. Explicit is good :)

@topiaruss
Copy link
Contributor Author

Well done. I'm enjoying using it. Thanks!

@topiaruss topiaruss deleted the patch-1 branch November 29, 2017 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants