Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gml_pragma("forceinline" does not work on methods #6327

Closed
gm-bug-reporter bot opened this issue Jun 18, 2024 · 4 comments
Closed

gml_pragma("forceinline" does not work on methods #6327

gm-bug-reporter bot opened this issue Jun 18, 2024 · 4 comments
Assignees
@rwkay @YYBartT
Labels
documentation Improvements or additions to documentation are required by this issue feature request New feature (or a request for one) runner-bug In-game bugs with the "GameMaker Studio 2" runtimes

Comments

@gm-bug-reporter
Copy link

Description

I would like methods to also support inline, but it seems to only have an effect on global functions. Not sure if thats intended or a technical limitation, but if its possible I would love to get that performance boost while still organizing some of my functionality in methods instead of global functions.

Which version of GameMaker are you reporting this issue for?

IDE v2024.4.1.152 Runtime v2024.4.1.202

Which operating system(s) are you seeing the problem on?

Windows 10.0.19045.0

781a131d-9af6-4143-a524-75dd9b7a0b90
@gm-bug-reporter gm-bug-reporter bot added the runner-bug In-game bugs with the "GameMaker Studio 2" runtimes label Jun 18, 2024
@stuckie stuckie moved this from Triage to Backlog in Team Workload Jun 19, 2024
@stuckie stuckie added the feature request New feature (or a request for one) label Jun 19, 2024
@rwkay
Copy link

rwkay commented Jun 19, 2024

inlining is left to the C++ compiler each have its own heuristics for actually implementing the inline - this is not something we have any plans to improve on the current compiler

@rwkay rwkay closed this as completed Jun 19, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Team Workload Jun 19, 2024
@YYBartT YYBartT added the documentation Improvements or additions to documentation are required by this issue label Jun 20, 2024
@YYBartT YYBartT self-assigned this Jun 20, 2024
@Retrific
Copy link

Does this mean in theory forceinline could also work on methods?

@rwkay
Copy link

rwkay commented Jun 24, 2024

Yes it should... but it is up to the C++ compiler what it does..

YYBartT added a commit to YoYoGames/GameMaker-Manual that referenced this issue Jun 25, 2024
@YYBartT
docs(general): gml_pragma("forceinline" does not work on methods
07c6dd7 
YoYoGames/GameMaker-Bugs#6327

* Updated the description of gml_pragma() to make it clear that this is a request that's not guaranteed
YYBartT added a commit to YoYoGames/GameMaker-Manual that referenced this issue Jun 25, 2024
@YYBartT
docs(general): gml_pragma("forceinline" does not work on methods
e68dc2e 
YoYoGames/GameMaker-Bugs#6327

* A few more changes to the description
@YYBartT
Copy link

YYBartT commented Jun 25, 2024

Modified the description of the "forceinline" pragma to clarify that this is only a request to the C++ compiler and that inlining is not guaranteed.

@YYBartT YYBartT moved this from Done to Ready for QA in Team Workload Jun 25, 2024
@YYBartT YYBartT mentioned this issue Jun 28, 2024
Merged
gurpreetsinghmatharoo pushed a commit to YoYoGames/GameMaker-Manual that referenced this issue Aug 8, 2024
@YYBartT @gurpreetsinghmatharoo
docs(general): gml_pragma("forceinline" does not work on methods
1c4861b 
YoYoGames/GameMaker-Bugs#6327

* Updated the description of gml_pragma() to make it clear that this is a request that's not guaranteed

(cherry picked from commit 07c6dd7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwkay rwkay

@YYBartT YYBartT

Labels
documentation Improvements or additions to documentation are required by this issue feature request New feature (or a request for one) runner-bug In-game bugs with the "GameMaker Studio 2" runtimes
Projects
Team Workload
Status: Ready for QA
Milestone
No milestone
Development

No branches or pull requests
4 participants
@stuckie @rwkay @Retrific @YYBartT