Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix player speed relying on english #101

Closed
VampireChicken12 opened this issue Nov 18, 2023 · 2 comments
Closed

Fix player speed relying on english #101

VampireChicken12 opened this issue Nov 18, 2023 · 2 comments
Assignees
@VampireChicken12
Labels
bug Something isn't working released

Comments

@VampireChicken12
Copy link
Member

VampireChicken12 commented Nov 18, 2023 •
edited
Loading

The following code relies on the language being English to get the player speed when it is adjusted

https://github.com/VampireChicken12/youtube-enhancer/blob/dev/src/features/playerSpeed/index.ts#L97
https://github.com/VampireChicken12/youtube-enhancer/blob/dev/src/features/playerSpeed/index.ts#L106
@VampireChicken12 VampireChicken12 converted this from a draft issue Nov 18, 2023
@VampireChicken12 VampireChicken12 self-assigned this Nov 18, 2023
@VampireChicken12 VampireChicken12 added the bug Something isn't working label Nov 18, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in YouTube Enhancer Nov 20, 2023
github-actions bot pushed a commit that referenced this issue Nov 20, 2023
@semantic-release-bot
chore(release): 1.12.0 [skip ci]
905b63c 
# [1.12.0](v1.11.8...v1.12.0) (2023-11-20)

### Bug Fixes

* restore player speed relying on English ([2a02eac](2a02eac)), closes [#101](#101)
* restore player speed relying on English ([25b5574](25b5574))
* screenshot tooltip wasn't appearing ([ceabdbd](ceabdbd))

### Features

* automatic theater mode ([fae29e4](fae29e4)), closes [#100](#100)
* **scroll wheel volume control:** modifier key enables volume adjustment with scroll ([53474a2](53474a2)), closes [#104](#104) [#110](#110)

## Release Artifacts
| File Name | SHA-256 Hash |
| :--- | :---: |
| youtube-enhancer-v1.12.0-Chrome.zip | 45629de6bf81d6326d8d97f717c1a7011613861b497bf79acdc920443214fd3e |
| youtube-enhancer-v1.12.0-Chromium.zip | 45629de6bf81d6326d8d97f717c1a7011613861b497bf79acdc920443214fd3e |
| youtube-enhancer-v1.12.0-Edge.zip | 45629de6bf81d6326d8d97f717c1a7011613861b497bf79acdc920443214fd3e |
| youtube-enhancer-v1.12.0-Firefox.zip | 05960ecb130d0410bf2884a1e77d43d7cbdca390ff83fdecfa62f5579db027dd |
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 1.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

VampireChicken12 added a commit that referenced this issue Nov 20, 2023
@VampireChicken12
fix: restore player speed relying on English
497c3c2 
Closes #101
VampireChicken12 added a commit that referenced this issue Nov 20, 2023
@VampireChicken12
fix: restore player speed relying on English
12a80ea 
Restoring custom speed now supported
Closes #101
github-actions bot pushed a commit that referenced this issue Nov 20, 2023
@semantic-release-bot
chore(release): 1.12.0 [skip ci]
de1097e 
# [1.12.0](v1.11.8...v1.12.0) (2023-11-20)

### Bug Fixes

* restore player speed relying on English ([12a80ea](12a80ea)), closes [#101](#101)
* screenshot tooltip wasn't appearing ([175ddf0](175ddf0))

### Features

* automatic theater mode ([79d425e](79d425e)), closes [#100](#100)
* **scroll wheel volume control:** modifier key enables volume adjustment with scroll ([4a11654](4a11654)), closes [#104](#104) [#110](#110)

## Release Artifacts
| File Name | SHA-256 Hash |
| :--- | :---: |
| youtube-enhancer-v1.12.0-Chrome.zip | 66f45b48286ee2a426521c2151a10a565a68350aba0a4da380fcb7493023fb43 |
| youtube-enhancer-v1.12.0-Chromium.zip | c9b34df55ab99cbc30b5350e77e4e30b7fae4be9b9bcf54f38cd980d24ba7d97 |
| youtube-enhancer-v1.12.0-Edge.zip | c9b34df55ab99cbc30b5350e77e4e30b7fae4be9b9bcf54f38cd980d24ba7d97 |
| youtube-enhancer-v1.12.0-Firefox.zip | f97916aef239961142585030cfd23e540dbcf5b91c104e574c57afee6d7196ab |
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 1.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@livingflore livingflore moved this to Done in YouTube Enhancer Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VampireChicken12 VampireChicken12

Labels
bug Something isn't working released
Projects
YouTube Enhancer
Status: Done - Released
Milestone
No milestone
Development

No branches or pull requests
1 participant
@VampireChicken12