Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Volume scroll: Only when a hotkey is held #104

Closed
ArchiveAnon opened this issue Nov 19, 2023 · 10 comments
Closed

Volume scroll: Only when a hotkey is held #104

ArchiveAnon opened this issue Nov 19, 2023 · 10 comments
Assignees
@VampireChicken12
Labels
enhancement New feature or request released

Comments

@ArchiveAnon
Copy link

Thank you for this extension and carrying on some useful features I really loved. I was wondering if it would be possible to implement a feature/option that only changed volume when scrolling if right click (or any hotkey really) was held down while scrolling. I find myself often accidentally changing volume without this and it would be a nice-to-have thing.

Thanks again for the effort, its greatly appreciated.
@VampireChicken12
Copy link
Member

@ArchiveAnon that should be possible. Right now I'm working on improving some of the code. I'm also making tests for the code to make sure everything is working before releasing the next version.

@VampireChicken12 VampireChicken12 added the enhancement New feature or request label Nov 19, 2023
@VampireChicken12 VampireChicken12 self-assigned this Nov 19, 2023
@VampireChicken12
Copy link
Member

@ArchiveAnon would the alt or ctrl key work? if I want to get this new feature out fast those two would be the easiest otherwise it will take a bit longer.

@ArchiveAnon
Copy link
Author

Honestly, any key works. Just can be a bit of an annoyance if you scroll and accidentally mute the video you're watching or blast the volume haha. Thanks for taking the time to do this!

@VampireChicken12
Copy link
Member

Alright, the easiest way for me to add this feature is "ctrl", "alt" or "shift" key press. Because in the event for the scroll wheel there are properties that tell if those keys are pressed when scrolling.

https://github.com/VampireChicken12/youtube-enhancer/blob/dev/src/features/scrollWheelVolumeControl/index.ts#L30

@VampireChicken12
Copy link
Member

VampireChicken12 commented Nov 19, 2023 •
edited
Loading

Although I can do it the harder way which will allow for a wider range of keys to choose from.
Below is a list of keys that could potentially be used.
https://keyjs.dev/#keycodes-table

@VampireChicken12
Copy link
Member

If you have Discord feel free to add me to talk about this new feature and other features. vampirechicken is my Discord username

@VampireChicken12
Copy link
Member

I decided that the following keys will be alright

Alt key, Ctrl key, Shift key

@VampireChicken12 VampireChicken12 mentioned this issue Nov 20, 2023
Closed
github-actions bot pushed a commit that referenced this issue Nov 20, 2023
@semantic-release-bot
chore(release): 1.12.0 [skip ci]
905b63c 
# [1.12.0](v1.11.8...v1.12.0) (2023-11-20)

### Bug Fixes

* restore player speed relying on English ([2a02eac](2a02eac)), closes [#101](#101)
* restore player speed relying on English ([25b5574](25b5574))
* screenshot tooltip wasn't appearing ([ceabdbd](ceabdbd))

### Features

* automatic theater mode ([fae29e4](fae29e4)), closes [#100](#100)
* **scroll wheel volume control:** modifier key enables volume adjustment with scroll ([53474a2](53474a2)), closes [#104](#104) [#110](#110)

## Release Artifacts
| File Name | SHA-256 Hash |
| :--- | :---: |
| youtube-enhancer-v1.12.0-Chrome.zip | 45629de6bf81d6326d8d97f717c1a7011613861b497bf79acdc920443214fd3e |
| youtube-enhancer-v1.12.0-Chromium.zip | 45629de6bf81d6326d8d97f717c1a7011613861b497bf79acdc920443214fd3e |
| youtube-enhancer-v1.12.0-Edge.zip | 45629de6bf81d6326d8d97f717c1a7011613861b497bf79acdc920443214fd3e |
| youtube-enhancer-v1.12.0-Firefox.zip | 05960ecb130d0410bf2884a1e77d43d7cbdca390ff83fdecfa62f5579db027dd |
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 1.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

VampireChicken12 added a commit that referenced this issue Nov 20, 2023
@VampireChicken12
feat(scroll wheel volume control): modifier key enables volume adjust…
74c794c 
…ment with scroll

Require a modifier key to be held

to adjust volume with scroll

Closes #104, #110
VampireChicken12 added a commit that referenced this issue Nov 20, 2023
@VampireChicken12
feat(scroll wheel volume control): modifier key enables volume adjust…
4a11654 
…ment with scroll

Require a modifier key to be held

to adjust volume with scroll

Closes #104, #110
github-actions bot pushed a commit that referenced this issue Nov 20, 2023
@semantic-release-bot
chore(release): 1.12.0 [skip ci]
de1097e 
# [1.12.0](v1.11.8...v1.12.0) (2023-11-20)

### Bug Fixes

* restore player speed relying on English ([12a80ea](12a80ea)), closes [#101](#101)
* screenshot tooltip wasn't appearing ([175ddf0](175ddf0))

### Features

* automatic theater mode ([79d425e](79d425e)), closes [#100](#100)
* **scroll wheel volume control:** modifier key enables volume adjustment with scroll ([4a11654](4a11654)), closes [#104](#104) [#110](#110)

## Release Artifacts
| File Name | SHA-256 Hash |
| :--- | :---: |
| youtube-enhancer-v1.12.0-Chrome.zip | 66f45b48286ee2a426521c2151a10a565a68350aba0a4da380fcb7493023fb43 |
| youtube-enhancer-v1.12.0-Chromium.zip | c9b34df55ab99cbc30b5350e77e4e30b7fae4be9b9bcf54f38cd980d24ba7d97 |
| youtube-enhancer-v1.12.0-Edge.zip | c9b34df55ab99cbc30b5350e77e4e30b7fae4be9b9bcf54f38cd980d24ba7d97 |
| youtube-enhancer-v1.12.0-Firefox.zip | f97916aef239961142585030cfd23e540dbcf5b91c104e574c57afee6d7196ab |
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 1.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@VampireChicken12
Copy link
Member

VampireChicken12 commented Nov 20, 2023 •
edited
Loading

@ArchiveAnon version v1.12.0 includes "Scroll wheel volume control modifier key feature"
YouTube_Enhancer__Options_-_Google_Chrome_e4DxUokOsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VampireChicken12 VampireChicken12

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@VampireChicken12 @ArchiveAnon