2. Cache unsolicited address messages, and use them as responses #3294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
P-Medium
C-security
1 task
Codecov Report
@@ Coverage Diff @@
## main #3294 +/- ##
==========================================
+ Coverage 77.19% 77.25% +0.05%
==========================================
Files 265 265
Lines 31445 31460 +15
==========================================
+ Hits 24275 24303 +28
+ Misses 7170 7157 -13 |
3 tasks
|
Bumping this up to high priority, because this fixes some occasional CI failures, and it might conflict with other PRs. |
teor2345
added
the
I-integration-fail
|
I've tested this PR locally, and the crawler and address book metrics look a lot better. The number of peer addresses rises rapidly, and gets full after a few hours. And Zebra doesn't hang any more, even after a few days. |
teor2345
force-pushed
the
fix-address-crawler-timing
branch
from
efd6bb0 to
fa44edf
Compare
teor2345
force-pushed
the
cache-unsolicited-addresses
branch
from
09c749b to
c28fd01
Compare
This was referenced Jan 2, 2022
teor2345
force-pushed
the
cache-unsolicited-addresses
branch
from
c28fd01 to
1153aa2
Compare
dconnolly
approved these changes
Jan 5, 2022
|
A pretty tight narrow addr cache 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Zebra's address crawler is fragile - small changes can cause significant regressions.
This PR caches unsolicited address messages, so that new addresses are always available when Zebra wants them.
Solution
Closes #3110
Review
This PR is ready for review.
@dconnolly can review this PR.
Reviewer Checklist
I've tested this PR locally, and the regression in the address book metrics is resolved. (We see thousands of addresses on mainnet, and over a hundred on testnet.) The number of peer addresses rises rapidly, and gets full after a few hours. And Zebra doesn't hang any more, even after a few days.
It's hard to test this PR, because the timing issues are subtle, and don't show up in some network environments. We should have better tests after we implement #1592.